-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to specify x-request-id header #6
base: main
Are you sure you want to change the base?
Conversation
There are a lot of code changes here for one new header. Can you summarize all the changes and how you implemented this? Some of the changes are only formatting. Also, I sense this is more work than is needed. There is already support for request-id, but it is always static. It seems you could add an optional parameter in this line, and therefore not need all the other changes: stock-api-libphp/src/Utils/APIUtils.php Line 36 in 99a6786
|
@chfabbro thanks for the review! To summarize:
I didn't add an additional parameter to Let me know if I should add an additional optional |
Hmm... I get multiple errors when I try to run the tests. Were you able to run tests, or were you not able to install |
@chfabbro if you confirm the changes, I will adjust the tests and add test coverage for the introduced functionality. |
I will need to wait for @slaanesh to review. He is the final approver of any changes to public Git, and created the rules for how submissions get approved. He is also much more familiar with PHP and code style than I am. |
@chfabbro tests are fixed and new functionality test coverage is provided. I did also fix the |
@sivaschenko Thanks! I sent you an offline Slack message. I will get a dev resource to help me review both of your PRs. I will also add you to the internal JIRA tickets I am creating for these. |
478fa61
to
52f28b2
Compare
Hi @chfabbro the formatting changes are removed from the pull request |
Added ability to specify x-request-id header.