-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-125482 Add dir property to rtl locales #118
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 6 6
Lines 468 468
=======================================
Hits 451 451
Misses 17 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@meganthecoder @Brandon32 @JasonHowellSlavin |
@aishwaryamathuria This needs to be verified first, which I believe @Dli3 is currently working on. Please review our contributing doc for further details on our process: https://github.com/adobecom/bacom/blob/main/CONTRIBUTING.md |
Hi @aishwaryamathuria , we're our PM to review the bugs reported in the MWPW-125482 ticket. |
Verified, thanks @aishwaryamathuria . |
Context
https://github.com/orgs/adobecom/discussions/746
Why this PR?
adobecom/milo#777
The above mentioned issue and requirement are fixed in milo in the shared PR.
How to use override?
Add the 'content-direction' meta tag with value 'rtl' or 'ltr' in the metadata block of the page or via metadata.xlsx to override the default text alignment.
Resolves: MWPW-125482
Test URLs: