MWPW-138026 Add tags to lana logs #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
requested review from
meganthecoder and
JasonHowellSlavin
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
Brandon32
force-pushed
the
bmarshal/lana-logs
branch
from
32a71d6 to
eaa5de4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 97.19% 97.19% -0.01%
==========================================
Files 8 8
Lines 714 712 -2
==========================================
- Hits 694 692 -2
Misses 20 20 ☔ View full report in Codecov by Sentry. |
amauch-adobe
approved these changes
Dec 7, 2023
meganthecoder
approved these changes
Dec 7, 2023
| @@ -6,8 +6,7 @@ export default async function init(el) { | |||
| const resp = await fetch(url); | |||
|
|
|||
| if (!resp?.ok) { | |||
| // eslint-disable-next-line no-console | |||
| console.log(`Error fetching data from url: ${url}`); | |||
| window.lana?.log(`Error fetching data from url: ${url}`, { tags: 'info, faas-decode' }); | |||
There was a problem hiding this comment.
I remember the tags being encoded at one point, I'm not sure if the space after the comma yields the expected results. Was this tested with the stage logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-138026
Test URLs: