Rolling import to DA #278
Rolling import to DA #278
Conversation
mokimo
requested review from
Brandon32,
JasonHowellSlavin and
meganthecoder
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #278 +/- ##
==========================================
+ Coverage 95.95% 96.80% +0.85%
==========================================
Files 11 13 +2
Lines 1088 1379 +291
==========================================
+ Hits 1044 1335 +291
Misses 44 44 ☔ View full report in Codecov by Sentry. |
|
1 similar comment
|
|
@Brandon32 @JasonHowellSlavin can one of you look into this PR and get it on main? (PS: The code is mostly from nexter - I tried to not change any code/style to make getting changes back in easier) It should listen to all publish hooks within bacom and publish those articles into DA bacom and have no prod influence on the bacom project itself |
| imgs.forEach((img) => { | ||
| const clone = img.cloneNode(true); | ||
| clone.setAttribute('loading', 'lazy'); | ||
| // clone.src = `${clone.src}?optimize=medium`; |
There was a problem hiding this comment.
did you want to leave this commented out code in?
There was a problem hiding this comment.
Yes, that's as it is in nexter too 😁
Description
Enables a rolling import to DA based on Nexters import script with small adaptions for IMS. Since this is a copy, we'll need to manually sync any updates that go into the nexter import script
Resolves: MWPW-164826
Test URLs: