fix(mwpw-136323): when you clear a filter group it now updates the url

adobecom · Sep 20, 2023 · 45a94f3 · 45a94f3
1 parent cabbfa5
commit 45a94f3
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 12 deletions.
diff --git a/dist/app.css b/dist/app.css
diff --git a/dist/main.js b/dist/main.js
@@ -1,5 +1,5 @@
 /*!
- * Chimera UI Libraries - Build 0.8.1 (9/8/2023, 01:47:03)
+ * Chimera UI Libraries - Build 0.8.2 (9/20/2023, 15:07:31)
  *         
  */
 /******/ (function(modules) { // webpackBootstrap
@@ -6842,16 +6842,19 @@ var Container = function Container(props) {
      * @returns {Void} - an updated state
      */
     var clearFilterItem = function clearFilterItem(id) {
+        var group = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : '';
+
         setFilters(function (prevFilters) {
             var filterClearedState = getFilterItemClearedState(id, prevFilters);
             return filterClearedState;
         });
 
         var urlParams = new URLSearchParams(window.location.search);
         clearUrlState();
+        // actually clear the url state
         urlParams.forEach(function (value, key) {
             var chFilter = key.toLowerCase().replace('ch_', '').replace(' ', '-');
-            if (key.indexOf(filterGroupPrefix) !== 0 || !id.includes(chFilter)) {
+            if (key.indexOf(filterGroupPrefix) !== 0 || !id.toLowerCase().includes(chFilter) || !group.toLowerCase().includes(chFilter)) {
                 setUrlState(key, value.replace('%20', ' '));
             }
         });
@@ -55551,7 +55554,7 @@ var Item = function Item(props) {
      * @listens ClickEvent
      */
     var handleClear = function handleClear() {
-        return onClearAll(id);
+        onClearAll(id, name);
     };
 
     /**
@@ -55624,6 +55627,7 @@ var Item = function Item(props) {
             ),
             shouldRenderSelectedBadge && _react2.default.createElement(_SelectedItem.SelectedItem, {
                 handleClear: handleClear,
+                id: id + '-clear',
                 numItemsSelected: numItemsSelected }),
             _react2.default.createElement(
                 'section',

diff --git a/dist/main.min.js b/dist/main.min.js
diff --git a/dist/main.source.js b/dist/main.source.js
diff --git a/react/src/js/components/Consonant/Container/Container.jsx b/react/src/js/components/Consonant/Container/Container.jsx
@@ -429,17 +429,19 @@ const Container = (props) => {
      * @param {Number} id - the id of an individual filter item
      * @returns {Void} - an updated state
      */
-    const clearFilterItem = (id) => {
+    const clearFilterItem = (id, group = '') => {
         setFilters((prevFilters) => {
             const filterClearedState = getFilterItemClearedState(id, prevFilters);
             return filterClearedState;
         });
 
         const urlParams = new URLSearchParams(window.location.search);
         clearUrlState();
+        // actually clear the url state
         urlParams.forEach((value, key) => {
             const chFilter = key.toLowerCase().replace('ch_', '').replace(' ', '-');
-            if (key.indexOf(filterGroupPrefix) !== 0 || !id.includes(chFilter)) {
+            if (key.indexOf(filterGroupPrefix) !== 0 || !id.toLowerCase().includes(chFilter) ||
+                !group.toLowerCase().includes(chFilter)) {
                 setUrlState(key, value.replace('%20', ' '));
             }
         });

diff --git a/react/src/js/components/Consonant/Filters/Left/Item.jsx b/react/src/js/components/Consonant/Filters/Left/Item.jsx
@@ -138,7 +138,9 @@ const Item = (props) => {
      * @param {ClickEvent} e
      * @listens ClickEvent
      */
-    const handleClear = () => onClearAll(id);
+    const handleClear = () => {
+        onClearAll(id, name);
+    };
 
     /**
      * Handles toggling the selected/unselected state of the left filter option
@@ -205,6 +207,7 @@ const Item = (props) => {
                     shouldRenderSelectedBadge &&
                     <DesktopSelectedItem
                         handleClear={handleClear}
+                        id={`${id}-clear`}
                         numItemsSelected={numItemsSelected} />
                 }
                 <section