Skip to content

Commit

Permalink
feat(mwpw-140454): hide banners when they are there
Browse files Browse the repository at this point in the history
  • Loading branch information
Sheridan Sunier committed May 21, 2024
1 parent 2da0970 commit 8cbca23
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 34 deletions.
4 changes: 2 additions & 2 deletions dist/app.css

Large diffs are not rendered by default.

6 changes: 1 addition & 5 deletions dist/main.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Chimera UI Libraries - Build 0.11.29 (5/9/2024, 13:19:43)
* Chimera UI Libraries - Build 0.11.29 (5/21/2024, 11:24:56)
*
*/
/******/ (function(modules) { // webpackBootstrap
Expand Down Expand Up @@ -46726,10 +46726,6 @@ var Card = function Card(props) {
isIcon && _react2.default.createElement(
'div',
{
style: {
backgroundColor: logoBg,
borderColor: logoBorderBg
},
'data-testid': 'consonant-Card-logo',
className: 'consonant-Card-logo' },
_react2.default.createElement('img', {
Expand Down
4 changes: 2 additions & 2 deletions dist/main.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/main.source.js

Large diffs are not rendered by default.

19 changes: 3 additions & 16 deletions less/components/consonant/cards/icon.less
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,9 @@

.font(1.125rem, 1.375rem, 700, @consonantGray900);
}
}

.consonant-Card-text {
display: -webkit-box;
-webkit-box-orient: vertical;
max-height: 1.3125rem * 3;
margin: 0 0 14px;
padding: 0;

.font(0.875rem, 1.3125rem, 400, @consonantGray700);

-webkit-line-clamp: 3;
overflow: hidden;

&:empty {
display: none;
}
}
.consonant-Card-banner {
display: none;
}
}
4 changes: 0 additions & 4 deletions react/src/js/components/Consonant/Cards/Card.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,6 @@ const Card = (props) => {
}
{isIcon &&
<div
style={({
backgroundColor: logoBg,
borderColor: logoBorderBg,
})}
data-testid="consonant-Card-logo"
className="consonant-Card-logo">
<img
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const renderCard = setup(Card, DEFAULT_PROPS_HALF_HEIGHT);
const cardStyle = 'half-height';

describe(`Consonant/Card/${cardStyle}`, () => {

test('should be able to render a card header', () => {
renderCard({
cardStyle,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ const getBookmarkedCards = [

const card1 = { id: 'card-id-1', tags: [{ id: 1 }, { id: 2 }] };
const card2 = { id: 'card-id-2', tags: [{ id: 1 }, { id: 2 }, { id: 3 }] };
const card3 = { id: 'card-id-3', };
const upcoming = { id: 'upcoming1', endDate: getDate((curDate + 240000)), startDate: getDate((curDate + 120000)),}
const card3 = { id: 'card-id-3' };
const upcoming = { id: 'upcoming1', endDate: getDate((curDate + 240000)), startDate: getDate((curDate + 120000)) };

const cards = [card1, card2, card3, upcoming];

Expand Down Expand Up @@ -203,7 +203,7 @@ const getFilteredCards = [
filterType: 'or',
filterTypes,
expectedValue: [upcoming],
}
},
];

const getFilteredCardsThrowError = {
Expand Down

0 comments on commit 8cbca23

Please sign in to comment.