feat(mwpw-140454): maybe fixed the lighthouse thing

adobecom · May 23, 2024 · d591b55 · d591b55
1 parent 9804e18
commit d591b55
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/dist/app.css b/dist/app.css
diff --git a/dist/main.js b/dist/main.js
@@ -1,5 +1,5 @@
 /*!
- * Chimera UI Libraries - Build 0.11.29 (5/23/2024, 15:10:17)
+ * Chimera UI Libraries - Build 0.11.29 (5/23/2024, 15:41:58)
  *         
  */
 /******/ (function(modules) { // webpackBootstrap
@@ -7970,6 +7970,7 @@ var Grid = function Grid(props) {
             'data-card-style': collectionStyleOverride,
             'data-testid': 'consonant-CardsGrid',
             className: gridClass,
+            role: 'tablist',
             'aria-live': isAriaLiveActive ? 'polite' : 'off' },
         cardsToshow.map(function (card, index) {
             var cardStyleOverride = (0, _general.getByPath)(card, 'styles.typeOverride');
@@ -46642,7 +46643,7 @@ var Card = function Card(props) {
     }
 
     var hasBanner = bannerDescriptionToUse && bannerFontColorToUse && bannerBackgroundColorToUse;
-    var headingAria = videoURL || label || detailText || description || logoSrc || badgeText || hasBanner && !disableBanners || isIcon ? '' : title;
+    var headingAria = videoURL || label || detailText || description || logoSrc || badgeText || hasBanner && !disableBanners || !isIcon ? '' : title;
 
     var ariaText = title;
     if (hasBanner && !disableBanners) {

diff --git a/dist/main.min.js b/dist/main.min.js
diff --git a/dist/main.source.js b/dist/main.source.js
diff --git a/react/src/js/components/Consonant/Cards/Card.jsx b/react/src/js/components/Consonant/Cards/Card.jsx
@@ -299,7 +299,7 @@ const Card = (props) => {
 
     const hasBanner = bannerDescriptionToUse && bannerFontColorToUse && bannerBackgroundColorToUse;
     const headingAria = (videoURL ||
-        label || detailText || description || logoSrc || badgeText || (hasBanner && !disableBanners) || isIcon) ? '' : title;
+        label || detailText || description || logoSrc || badgeText || (hasBanner && !disableBanners) || !isIcon) ? '' : title;
 
     let ariaText = title;
     if (hasBanner && !disableBanners) {

diff --git a/react/src/js/components/Consonant/Grid/Grid.jsx b/react/src/js/components/Consonant/Grid/Grid.jsx
@@ -207,6 +207,7 @@ const Grid = (props) => {
             data-card-style={collectionStyleOverride}
             data-testid="consonant-CardsGrid"
             className={gridClass}
+            role="tablist"
             aria-live={isAriaLiveActive ? 'polite' : 'off'}>
             {cardsToshow.map((card, index) => {
                 const cardStyleOverride = getByPath(card, 'styles.typeOverride');