-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MWPW-162733): enforce JIRA ticket number in PR title scope #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanrai
changed the title
feat(MWPW-1234): enforce pr title to follow commit lint
feat(foo): enforce pr title to follow commit lint [MWPW-1234]
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint [MWPW-1234]
feat(foo): enforce pr title to follow commit lint
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint
feat(foo): enforce pr title to follow commit lint asASs
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint asASs
feat(foo): enforce pr title to follow commit lint BAR
Nov 19, 2024
raissanjay
changed the title
feat(foo): enforce pr title to follow commit lint BAR
feat(foo): enforce pr title to follow commit lint
Nov 19, 2024
raissanjay
changed the title
feat(foo): enforce pr title to follow commit lint
feat(foo): enforce pr title to follow commit lint 2
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint 2
feat(foo): enforce pr title to follow commit lint 3
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint 3
feat(foo): enforce pr title to follow commit lint MWPW-123
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint MWPW-123
feat(foo): enforce pr title to follow commit lint
Nov 19, 2024
sanrai
changed the title
feat(foo): enforce pr title to follow commit lint
feat(MWPW-123): enforce pr title to follow commit lint
Nov 19, 2024
sanrai
changed the title
feat(MWPW-123): enforce pr title to follow commit lint
feat(MWPW-123): Enforce JIRA ticket number in PR title scope
Nov 19, 2024
sanrai
changed the title
feat(MWPW-123): Enforce JIRA ticket number in PR title scope
feat(MWPW-162733): Enforce JIRA ticket number in PR title scope
Nov 19, 2024
raissanjay
changed the title
feat(MWPW-162733): Enforce JIRA ticket number in PR title scope
feat(MWPW-162733): enforce JIRA ticket number in PR title scope
Nov 19, 2024
raissanjay
temporarily deployed
to
github-pages
November 19, 2024 12:36 — with
GitHub Actions
Inactive
sanrai
requested review from
cmiqueo,
jedjedjedM,
sheridansunier,
gmirijan and
shkhan91
November 19, 2024 12:38
raissanjay
temporarily deployed
to
github-pages
November 20, 2024 09:17 — with
GitHub Actions
Inactive
Core Web Vitals Metrics
Recorded at: 2024-11-20T09:19:57.043Z |
gmirijan
temporarily deployed
to
github-pages
November 22, 2024 08:33 — with
GitHub Actions
Inactive
Core Web Vitals Metrics
Recorded at: 2024-11-22T08:35:50.382Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enforces consistent PR title format requiring JIRA ticket numbers to be in the scope section of the conventional commit format. For example:
feat(MWPW-123): add feature
Changes
type(MWPW-XXX): description
is followedTesting Instructions
Create a new PR with these incorrect formats (should fail):
feat: add feature
feat(foo): add feature
feat: MWPW-123 add feature
Create a PR with these correct formats (should pass):
feat(MWPW-123): add feature
fix(MWPW-456): fix bug
Try editing an existing PR title to an invalid format - check that the status check fails
Test Instructions
Prerequisites
npm install
Test Cases
1. Invalid PR Title Formats (Should Fail)
Create PRs with these titles and verify they fail the check:
feat: add new feature
feat(frontend): add feature
MWPW-123 feat: add feature
feat: MWPW-123 add feature
feat(MWPW): add feature
feat(MWPW-ABC): add feature
2. Valid PR Title Formats (Should Pass)
Create PRs with these titles and verify they pass the check:
feat(MWPW-123): add feature
fix(MWPW-456): fix bug
docs(MWPW-789): update readme
chore(MWPW-101): update dependencies
3. PR Title Editing
feat(MWPW-123): add feature
feat: add feature
4. Local Development Check
5. Edge Cases
Test these scenarios:
feat(MWPW-123): fix 404 error
feat(MWPW-123): add @ symbol support
feat(MWPW-123): add very long feature description that spans multiple words
Expected Results
How to Report Issues
If you find any issues:
Resolves: MWPW-162733