fix(mwpw-165609): restore card collection rendering by correcting getAttribute implementation #219
+16
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Attribute implementation Fixes critical production issue where card collection fails to render, displaying system error instead of event cards. Issue was caused by incorrect attribute handling in ConsonantPageModel. MWPW-165609
sanrai
requested review from
cmiqueo and
sheridansunier
and removed request for
cmiqueo
Core Web Vitals Metrics
Recorded at: 2025-01-15T03:20:18.161Z |
Core Web Vitals Metrics
Recorded at: 2025-01-15T03:21:41.444Z |
sheridansunier
approved these changes
Jan 15, 2025
cmiqueo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes critical production issue where card collection fails to render, displaying system error instead of event cards. Issue was caused by incorrect attribute handling in ConsonantPageModel.
Description
Fixes critical production issue where card collection fails to render, displaying system error instead of event cards. Issue was caused by incorrect attribute handling in ConsonantPageModel.
Changes
Testing
Production Impact
This PR addresses a critical production issue that required rollback of previous release.
Related Issues
Resolves: https://jira.corp.adobe.com/browse/MWPW-165609