Merge pull request #378 from adobecom/fixworkflow

Update workflow
adobecom · Sep 18, 2023 · 9701000 · 9701000
2 parents e73513d + 4704eab
commit 9701000
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/.github/workflows/test-milo.yml b/.github/workflows/test-milo.yml
@@ -30,6 +30,13 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+            browser: firefox
+          - os: windows-latest
+            browser: chromium
+          - os: macos-latest
+            browser: webkit          
     name: Smoke Test
     runs-on: ${{ matrix.os }}
     steps:
@@ -47,21 +54,16 @@ jobs:
         if: steps.cache.outputs.cache-hit != 'true'
         run: npm ci --ignore-scripts
 
+      - name: Install browsers
+        run: npx playwright install --with-deps ${{ matrix.browser }}
+
       - name: Run the tests
-        run:   |
-          if [ "$RUNNER_OS" == "Linux" ]; then
-              npx playwright install --with-deps firefox
-              xvfb-run -a npx run test/e2e/frictionless -t "@smoke and not @analytics" --browser firefox
-          elif [ "$RUNNER_OS" == "macOS" ]; then
-              npx playwright install --with-deps webkit
-              npx run test/e2e/frictionless -t "@smoke and not @analytics" --browser webkit
-          else
-              npx playwright install --with-deps chromium
-              npx run test/e2e/frictionless -t "@smoke and not @analytics"
-          fi
-        shell: bash
+        run: npx run test/e2e/frictionless -t "@smoke and not @analytics" -h -p prod -b ${{ matrix.browser }} --bypassBotDetection
+        env:
+          USER_AGENT_SUFFIX: "${{ secrets.USER_AGENT_SUFFIX }}"
 
       - name: Save test logs
+        if: ${{ always() }}
         uses: actions/upload-artifact@v3
         with:
           name: reports