Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-136128: Added star-outline icon #379

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

@zagi25 zagi25 added this to the 0.2339 milestone Sep 18, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #379 (190caee) into stage (0d0c604) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage     #379   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          25       25           
  Lines        2927     2927           
=======================================
  Hits         2731     2731           
  Misses        196      196           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@zagi25 zagi25 force-pushed the MWPW-136128-star-rating-rotate branch from 208344e to 88a3521 Compare September 18, 2023 08:26
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 18, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@zagi25
Copy link
Collaborator Author

zagi25 commented Sep 18, 2023

@Blainegunn, @saragajic11 , @puruadobe I think we should create a separate ticket for fixing stylelint errors because there is a lot of them , and also we should probably change some of the lint rules .

Copy link
Collaborator

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but could you fix the linting issues please? i know they aren't yours but just as a courtesy 🙏

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@zagi25 zagi25 force-pushed the MWPW-136128-star-rating-rotate branch from 552f387 to 2f172ca Compare September 20, 2023 09:25
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@zagi25 zagi25 force-pushed the MWPW-136128-star-rating-rotate branch from 2f172ca to 190caee Compare September 20, 2023 09:44
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Blainegunn Blainegunn merged commit 50f8af0 into stage Sep 21, 2023
@Blainegunn Blainegunn deleted the MWPW-136128-star-rating-rotate branch November 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants