MWPW-136317 Dropzone enabled on L1 verbs (plus compress) except rotate #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
peller
reviewed
Sep 20, 2023
peller
requested changes
Sep 20, 2023
peller
approved these changes
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## stage #381 +/- ##
==========================================
+ Coverage 93.30% 93.46% +0.15%
==========================================
Files 25 25
Lines 2927 2921 -6
==========================================
- Hits 2731 2730 -1
+ Misses 196 191 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Formatted only my code changes so that it's easy to review. @Blainegunn The lint errors are not related to the newly introduced changes. |
|
puruadobe
changed the title
|
|
|
|
|
|
|
|
Blainegunn
approved these changes
Sep 21, 2023
|
@puruadobe @Blainegunn is there anything blocking here? Can we get this on stage? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropzone enabled for the following L1 verbs plus compress (exclude rotate), rest of the verbs will have it only for the first visit.
Resolves https://jira.corp.adobe.com/browse/MWPW-136317
Before:
https://stage--dc--adobecom.hlx.live/acrobat/online/sign-pdf?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/request-signature?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/pdf-editor?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/delete-pdf-pages?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/compress-pdf?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/rearrange-pdf?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/split-pdf?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/add-pages-to-pdf?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/extract-pdf-pages?martech=off
https://stage--dc--adobecom.hlx.live/acrobat/online/crop-pdf?martech=off
After:
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/sign-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/request-signature?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/pdf-editor?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/delete-pdf-pages?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/compress-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/rearrange-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/split-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/add-pages-to-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/extract-pdf-pages?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/crop-pdf?martech=off
https://puru-mwpw-136317--dc--puruadobe.hlx.live/acrobat/online/add-pdf-page-numbers?martech=off