Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-132336 Analytics test for browser ext modal #384

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

TsayAdobe
Copy link
Collaborator

  • Due to the bug, a specialized network capture for Chromium is implemented, instead of using Playwright's interfaces.
  • Use a YAML file for analytic specs, which are the analytics logs to be verified.
  • Update the page object to support both Chrome and Edge extension modal dialogs.
  • Disable ESLint for test/e2e for now.

@TsayAdobe TsayAdobe added the test Fix or stabilize the current test label Sep 22, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 22, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #384 (6f9985c) into stage (0320c53) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #384      +/-   ##
==========================================
+ Coverage   93.40%   93.43%   +0.03%     
==========================================
  Files          25       25              
  Lines        2925     2925              
==========================================
+ Hits         2732     2733       +1     
+ Misses        193      192       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TsayAdobe TsayAdobe merged commit d6fd871 into stage Sep 27, 2023
@TsayAdobe TsayAdobe deleted the MWPW-132336 branch September 27, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Fix or stabilize the current test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants