Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-135907 - sign pdf and rotate pdf to l2 test #393

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

draganatrajkovic
Copy link
Collaborator

@draganatrajkovic draganatrajkovic commented Sep 28, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@draganatrajkovic draganatrajkovic changed the title MWPW-35907 - sign pdf and rotate pdf to l2 test MWPW-135907 - sign pdf and rotate pdf to l2 test Sep 28, 2023
@Blainegunn Blainegunn added this to the 0.2340 milestone Sep 28, 2023
Copy link
Contributor

@JFernandezAdobe JFernandezAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @draganatrajkovic! Please note that we have other tests for L2 verbs that focus on event-driven content. See eventwrapper.feature.

I logged a separate ticket for it - MWPW-137181.

| sign-pdf | test-files/test.pdf |

@MWPW-135907 @regression @converter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the tag with @MWPW-137180.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this, can you please check?

| rotate-pdf | test-files/test.pdf,test-files/test2.pdf |

@MWPW-135907 @regression @converter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please log a Test ticket and use the Jira ID as tag here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also resolved, please check

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/acrobat/ Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/compress-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #393 (50de23b) into stage (bd45cac) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #393      +/-   ##
==========================================
+ Coverage   93.40%   93.43%   +0.03%     
==========================================
  Files          25       25              
  Lines        2925     2925              
==========================================
+ Hits         2732     2733       +1     
+ Misses        193      192       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TsayAdobe TsayAdobe merged commit 7e4179c into stage Oct 2, 2023
6 of 7 checks passed
@Blainegunn Blainegunn deleted the mwpw-135907-sign-pdf-rotate-pdf-to-l2-test branch November 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants