Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-137111: Added modal animation only to extension modal #394

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/acrobat/how-to/convert-excel-to-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/acrobat/how-to/convert-excel-to-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #394 (d42d32e) into stage (def59ec) will not change coverage.
Report is 5 commits behind head on stage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage     #394   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          25       25           
  Lines        2925     2925           
=======================================
  Hits         2732     2732           
  Misses        193      193           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zagi25 zagi25 force-pushed the MWPW-137111-region-selector-modal branch from 94ff6eb to d42d32e Compare September 29, 2023 06:59
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/acrobat/how-to/convert-excel-to-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/acrobat/how-to/convert-excel-to-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@puruadobe puruadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/acrobat/how-to/convert-excel-to-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/acrobat/online/rotate-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Blainegunn Blainegunn merged commit 6bc39fb into stage Oct 3, 2023
6 of 7 checks passed
@Blainegunn Blainegunn deleted the MWPW-137111-region-selector-modal branch November 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants