-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-136133 #408
MWPW-136133 #408
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL:DR; adding box-sizing: content-box
should achieve what you want.
When you use chrome overrides and set a breakpoint/debugger/return statement just before/after decorateDocumentExtras
you can see the global navigation taking up 64+33px before calling decorateDocumentExtras
, then 64px after & 64+33px after the global navigation actually loads.
@@ -6,13 +6,13 @@ | |||
* | |||
* | |||
*/ | |||
header { | |||
min-height: 64px; | |||
} | |||
|
|||
@media (min-width: 900px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are also adding header.global-navigation { ... box-sizing: content-box; }
which should help to keep the CLS away
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great now!
|
2f8444d
to
154273c
Compare
|
Codecov Report
@@ Coverage Diff @@
## stage #408 +/- ##
==========================================
+ Coverage 93.44% 93.53% +0.09%
==========================================
Files 26 26
Lines 2988 2987 -1
==========================================
+ Hits 2792 2794 +2
+ Misses 196 193 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Resolves MWPW-136133
https://mwpw-136133--dc--adobecom.hlx.page/acrobat/online/pdf-to-ppt