Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-136133 #408

Merged
merged 4 commits into from
Oct 10, 2023
Merged

MWPW-136133 #408

merged 4 commits into from
Oct 10, 2023

Conversation

Blainegunn
Copy link
Collaborator

@Blainegunn Blainegunn commented Oct 9, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@Blainegunn Blainegunn added this to the 0.2342 milestone Oct 9, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@Blainegunn Blainegunn requested review from peller and mokimo October 9, 2023 20:47
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 9, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

Copy link

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL:DR; adding box-sizing: content-box should achieve what you want.


When you use chrome overrides and set a breakpoint/debugger/return statement just before/after decorateDocumentExtras you can see the global navigation taking up 64+33px before calling decorateDocumentExtras, then 64px after & 64+33px after the global navigation actually loads.

Screenshot 2023-10-10 at 10 14 02

acrobat/scripts/scripts.js Show resolved Hide resolved
@@ -6,13 +6,13 @@
*
*
*/
header {
min-height: 64px;
}

@media (min-width: 900px) {
Copy link

@mokimo mokimo Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also adding header.global-navigation { ... box-sizing: content-box; } which should help to keep the CLS away

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

Copy link

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks great now!

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

Codecov Report

Merging #408 (154273c) into stage (9d0e600) will increase coverage by 0.09%.
Report is 8 commits behind head on stage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #408      +/-   ##
==========================================
+ Coverage   93.44%   93.53%   +0.09%     
==========================================
  Files          26       26              
  Lines        2988     2987       -1     
==========================================
+ Hits         2792     2794       +2     
+ Misses        196      193       -3     
Files Coverage Δ
acrobat/scripts/scripts.js 96.91% <100.00%> (+0.55%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Blainegunn Blainegunn merged commit b9fb5c9 into stage Oct 10, 2023
@Blainegunn Blainegunn deleted the MWPW-136133 branch November 14, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants