Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test #411

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Fix unit test #411

merged 5 commits into from
Oct 13, 2023

Conversation

TsayAdobe
Copy link
Collaborator

@TsayAdobe TsayAdobe commented Oct 10, 2023

  • Fix npm test command. Use && between two commands.
  • Fix a failed test in eventwrapper
  • Improve dc-converter-widget coverage

@TsayAdobe TsayAdobe added trivial PR doesn't require E2E testing by a reviewer test Fix or stabilize the current test labels Oct 10, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #411 (50b1961) into stage (e0fd78c) will increase coverage by 3.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #411      +/-   ##
==========================================
+ Coverage   93.50%   96.58%   +3.08%     
==========================================
  Files          26       26              
  Lines        2985     2985              
==========================================
+ Hits         2791     2883      +92     
+ Misses        194      102      -92     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Page Scores Audits Google
/fr/acrobat/online/request-signature Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/compress-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/request-signature Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 12, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/fr/acrobat/online/request-signature Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Page Scores Audits Google
/acrobat/online/convert-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/request-signature Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/compress-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/request-signature Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI
/acrobat/online/convert-pdf Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@TsayAdobe TsayAdobe merged commit 79b5833 into stage Oct 13, 2023
6 of 7 checks passed
@TsayAdobe TsayAdobe deleted the unittestfix branch October 13, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Fix or stabilize the current test trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants