Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-132031 #424

Merged
merged 8 commits into from
Oct 18, 2023
Merged

MWPW-132031 #424

merged 8 commits into from
Oct 18, 2023

Conversation

Moving Icons to milo libs, image array names = country code, removing old array codenames
Removing lazy loading
Adding on error as a attribute. After loadArea runs event listeners does not exist.
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 18, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 18, 2023

Page Scores Audits Google
/de/drafts/rivero/credit-cards Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 18, 2023

Page Scores Audits Google
/de/drafts/rivero/credit-cards Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 401) PSI

@codecov-commenter
Copy link

Codecov Report

Merging #424 (d4a87e7) into stage (934d55e) will increase coverage by 3.09%.
Report is 26 commits behind head on stage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #424      +/-   ##
==========================================
+ Coverage   93.50%   96.59%   +3.09%     
==========================================
  Files          26       26              
  Lines        2987     2970      -17     
==========================================
+ Hits         2793     2869      +76     
+ Misses        194      101      -93     
Files Coverage Δ
acrobat/scripts/imageReplacer.js 100.00% <100.00%> (ø)
acrobat/scripts/scripts.js 96.91% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Blainegunn Blainegunn merged commit 29f1b2f into stage Oct 18, 2023
5 of 7 checks passed
@Blainegunn Blainegunn deleted the MWPW-132031 branch November 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants