-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-141047 CI/CD for Akamai edge worker code #532
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #532 +/- ##
==========================================
+ Coverage 99.02% 99.27% +0.25%
==========================================
Files 26 32 +6
Lines 2961 3856 +895
==========================================
+ Hits 2932 3828 +896
+ Misses 29 28 -1 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,18 @@ | |||
import stage from './stage.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way we can link everything in the csp/ folder to https://github.com/adobecom/dc/tree/stage/acrobat/scripts/contentSecurityPolicy
@@ -0,0 +1,11 @@ | |||
const fs = require('fs'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we want is stg2prod? Typically, we should be promoting changes from stage to prod only. Note: we have a way to detect isProd from the environment without hard-coding it. I'll work on that separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you update to the latest edgeworker code on stage, isProd
is discovered based on the environment. It no longer needs to be updated here.
.github/workflows/deploy-edgeworker.yml
edgewokers
test/edgeworkers
main.js
in theutils
folder.npm test
andnpm run jest
.edgeworkers/scripts/build.js
, which copies the dependency files to the bundle directory.edgeworkers/scripts/prod2stg.js
, which copies the prod edge worker directory to the stage one and modify some flags for the stage environment.bundle.json