Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for Main: stage into main #551

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Ready for Main: stage into main #551

merged 6 commits into from
Feb 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Merge to main, commit: 9ef8fc4

Copy link

aem-code-sync bot commented Feb 14, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cdfb7fd) 98.63% compared to head (f3fd877) 98.64%.
Report is 8 commits behind head on main.

Files Patch % Lines
acrobat/scripts/scripts.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   98.63%   98.64%           
=======================================
  Files          27       26    -1     
  Lines        3007     2954   -53     
=======================================
- Hits         2966     2914   -52     
+ Misses         41       40    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

|| window.location.pathname.match('/documentcloud/')
|| window.location.pathname.match('/acrobat/business/')) {
CONFIG.jarvis.id = 'DocumentCloudsignAcro';
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-extra-semi> reported by reviewdog 🐶
Unnecessary semicolon.

Suggested change
};
}

@Blainegunn Blainegunn merged commit 2747515 into main Feb 20, 2024
3662 of 3666 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants