Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-142806 #554

Closed
wants to merge 2 commits into from
Closed

MWPW-142806 #554

wants to merge 2 commits into from

Conversation

Blainegunn
Copy link
Collaborator

Resolves : MWPW-142806

Copy link

aem-code-sync bot commented Feb 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f3fd877) 98.64% compared to head (26ab9bb) 98.61%.

Files Patch % Lines
acrobat/scripts/scripts.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #554      +/-   ##
==========================================
- Coverage   98.64%   98.61%   -0.04%     
==========================================
  Files          26       26              
  Lines        2954     2955       +1     
==========================================
  Hits         2914     2914              
- Misses         40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -275,14 +275,15 @@ const CONFIG = {
version: '1.0',
onDemand: false,
},
imsScope: 'AdobeID,openid,gnav,firefly_api,adobeid.scope',
Copy link

@narcis-radu narcis-radu Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Blainegunn ! Milo-college projects will inherit the default scope from Milo as mentioned in the wiki, my plan is to add the pps.read and firefly_api scopes as soon as I'm done with validating that all IMS Client IDs have the scopes approved.
If you want to override the scopes, that's fine, but you will need to add pps.read, firefly_api not adobeid.scope. However, I think it's better if you get them from Milo, this way you're always in sync.

@Blainegunn Blainegunn closed this Feb 20, 2024
@Blainegunn Blainegunn deleted the MWPW-142806 branch March 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants