MWPW-144463 Added E2E test geo ip phone number #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #621 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 34 34
Lines 4088 4088
=======================================
Hits 4012 4012
Misses 76 76 ☔ View full report in Codecov by Sentry. |
Blainegunn
approved these changes
Apr 8, 2024
TsayAdobe
reviewed
Apr 8, 2024
| Given I go to the DC page '<urlPath>' | ||
| Then I record phone number on the page | ||
| Then I go to the page "<urlPath>" with geo-ip spoof "<countryCode>" | ||
| Then I confirm phone number is not changed |
There was a problem hiding this comment.
Shouldn't the number be changed?
There was a problem hiding this comment.
Hi James, I've just updated a test, please have a look:
830ecb8
# Conflicts: # test/e2e/step-definitions/dc.steps.js
aem-code-sync
bot
temporarily deployed
to
mwpw-144463-geo-ip-phone-number
TsayAdobe
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-144463