DC MILO 0.2434 #769
DC MILO 0.2434 #769
Conversation
update preloads for ims v2 token
MWPW-147558: Integration tests for icon-block
MWPW-155492: Mobile Widget Analytics can_donwload
MWPW-154096 Add unit tests for acom-widget
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MWPW-154530
MWPW-156535 Catch error if limits fail, trigger error screen
MWPW-156372
Revert "MWPW-156372"
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MWPW-155492
DCXY-25845 Don't use IMS guest token for redirected workflows
Mwpw 147557 media integration test
Project Unity: New Block for UI
pass detail from widget failures
use backticks
Updates to acom widget UI
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -8,182 +8,186 @@ import { | |||
| getAcrobatWebLink, | |||
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getAcrobatWebLink' is defined but never used.
|
|
||
|
|
There was a problem hiding this comment.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
More than 1 blank line not allowed.
| import { setLibs } from '../../scripts/utils.js'; | ||
|
|
||
| const miloLibs = setLibs('/libs'); | ||
| const { createTag } = await import(`${miloLibs}/utils/utils.js`); | ||
|
|
||
| // eslint-disable-next-line compat/compat | ||
| const PAGE_URL = new URL(window.location.href); | ||
| const redirect = PAGE_URL.searchParams.get('redirect'); |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'redirect' is assigned a value but never used.
| const { progressBarWrapper, progressBar } = progressSection; | ||
| const statusBar = document.querySelector('.status-bar'); | ||
| const cancelButton = document.querySelector('.widget-cancel'); | ||
| const uploadToAdobe = async (file, verb, err) => { | ||
| const filename = file.name; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'filename' is assigned a value but never used.
| const filename = file.name; | ||
| const extension = filename.split('.').pop().toLowerCase(); | ||
| let xhr; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'xhr' is defined but never used.
| } | ||
| }); | ||
| } else { | ||
| [...ev.dataTransfer.files].forEach((file, i) => { |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'i' is defined but never used.
| cancelButton: document.querySelector('.cancel-button'), | ||
| }); | ||
| const setDraggingClass = (widget, shouldToggle) => { | ||
| shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging'); |
There was a problem hiding this comment.
🚫 [eslint] <chai-friendly/no-unused-expressions> reported by reviewdog 🐶
Expected an assignment or function call and instead saw an expression.
| }); | ||
| const setDraggingClass = (widget, shouldToggle) => { | ||
| shouldToggle ? widget.classList.add('dragging') : widget.classList.remove('dragging'); | ||
| } |
| const widgetRight = createTag('div', { class: 'acom-col' }); | ||
| const widgetHeader = createTag('div', { class: 'acom-header' }); | ||
| const widgetIcon = createTag('div', { class: 'acom-icon' }); | ||
| const widgetTitle = createTag('div', { class: 'acom-title' }, 'Acrobat'); |
There was a problem hiding this comment.
🚫 [eslint] <no-multi-spaces> reported by reviewdog 🐶
Multiple spaces found before 'createTag'.
| const widgetTitle = createTag('div', { class: 'acom-title' }, 'Acrobat'); | |
| const widgetTitle = createTag('div', { class: 'acom-title' }, 'Acrobat'); |
| setDraggingClass(widget, true); | ||
| }); | ||
|
|
||
| widget.addEventListener('dragleave', (file) => { |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'file' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'initializePdfAssetManager' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'validateSSRF' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'createPdf' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'checkJobStatus' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getDownloadUri' is defined but never used.
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'prepareFormData' is defined but never used.
DC MILO 0.2434 Release