-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-157166 #802
MWPW-157166 #802
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #802 +/- ##
==========================================
+ Coverage 90.16% 90.20% +0.03%
==========================================
Files 43 43
Lines 5512 5511 -1
==========================================
+ Hits 4970 4971 +1
+ Misses 542 540 -2 ☔ View full report in Codecov by Sentry. |
Thanks for the PR @Blainegunn as discussed over call unity will be sending an event so that DC can handle the analytics call for the events that have been commented. cc @sanjayms01 |
Resolves : MWPW-157166
We are removing the
EventListener
on our side forchange
anddrop
to allow the Unity Team to use it conflict free.In exchange they will dispatch a new event called
unity:track-analytics
. This event will also carry details on whether it's a drop or change event so we can keep our code functioning as it was before.Thank you