Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157166 #802

Merged
merged 3 commits into from
Sep 16, 2024
Merged

MWPW-157166 #802

merged 3 commits into from
Sep 16, 2024

Conversation

Blainegunn
Copy link
Collaborator

@Blainegunn Blainegunn commented Sep 13, 2024

Resolves : MWPW-157166

We are removing the EventListener on our side for change and drop to allow the Unity Team to use it conflict free.
In exchange they will dispatch a new event called unity:track-analytics. This event will also carry details on whether it's a drop or change event so we can keep our code functioning as it was before.
Thank you

@Blainegunn Blainegunn added this to the 0.2428 milestone Sep 13, 2024
Copy link

aem-code-sync bot commented Sep 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (0d6298f) to head (6bc2369).
Report is 2 commits behind head on stage.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #802      +/-   ##
==========================================
+ Coverage   90.16%   90.20%   +0.03%     
==========================================
  Files          43       43              
  Lines        5512     5511       -1     
==========================================
+ Hits         4970     4971       +1     
+ Misses        542      540       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ruchika4
Copy link
Contributor

Thanks for the PR @Blainegunn as discussed over call unity will be sending an event so that DC can handle the analytics call for the events that have been commented. cc @sanjayms01

@Blainegunn Blainegunn merged commit 5ab1856 into stage Sep 16, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants