Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157036: Nonprofit form with api integration #808

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Conversation

st-angelo-adobe
Copy link
Collaborator

@st-angelo-adobe st-angelo-adobe commented Sep 17, 2024

Copy link

aem-code-sync bot commented Sep 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Blainegunn Blainegunn added this to the 0.2428 milestone Sep 17, 2024
@Blainegunn Blainegunn merged commit e66b687 into stage Sep 17, 2024
4 of 7 checks passed
)
.then((response) => response.json())
.then((result) => {
console.log(result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

organizationsStore.update(result.data);
})
.catch((error) => {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

})
.then((response) => response.json())
.then((result) => {
console.log(result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

organizationsStore.update((prev) => [...prev, ...result.data]);
})
.catch((error) => {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

})
.then((response) => response.json())
.then((result) => {
console.log(result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

registriesStore.update(result.data);
})
.catch((error) => {
console.log(error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.


async function sendOrganizationData() {
// todo
console.log(nonprofitFormData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1538 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (4babb81) to head (73d3d10).
Report is 183 commits behind head on stage.

Files with missing lines Patch % Lines
acrobat/blocks/nonprofit/nonprofit.js 0.00% 805 Missing ⚠️
acrobat/blocks/nonprofit/constants.js 0.00% 427 Missing ⚠️
acrobat/blocks/nonprofit/select.js 0.00% 256 Missing ⚠️
acrobat/scripts/reactiveStore.js 0.00% 50 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            stage     #808       +/-   ##
===========================================
- Coverage   97.10%   70.45%   -26.65%     
===========================================
  Files          39       47        +8     
  Lines        4906     7108     +2202     
===========================================
+ Hits         4764     5008      +244     
- Misses        142     2100     +1958     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 /drafts/astatescu/nonprofit/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/astatescu/nonprofit/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants