Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161088 update #879

Merged
merged 1 commit into from
Oct 29, 2024
Merged

MWPW-161088 update #879

merged 1 commit into from
Oct 29, 2024

Conversation

Blainegunn
Copy link
Collaborator

Resovles : MWPW-161088

Copy link

aem-code-sync bot commented Oct 28, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (b41163b) to head (8782b28).
Report is 4 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #879   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files          48       48           
  Lines        6138     6138           
=======================================
  Hits         5200     5200           
  Misses        938      938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn added this to the 0.2444 milestone Oct 28, 2024
Copy link
Collaborator

@TsayAdobe TsayAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you don't have to update the one in the edgeworkers folder. The deployment script will overwrite it with the one in the acrobat folder.

https://github.com/adobecom/dc/blob/stage/edgeworkers/scripts/build.js

@Blainegunn Blainegunn merged commit f513062 into stage Oct 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants