Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161334 Workaround Safari's ReferenceError when using a top-level await #883

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Copy link

aem-code-sync bot commented Oct 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 31, 2024

Page Scores Audits Google
📱 /acrobat/generative-ai-pdf/resume-ai PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /acrobat/generative-ai-pdf/resume-ai PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (f5a8226) to head (8f2d404).
Report is 3 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #883      +/-   ##
==========================================
+ Coverage   84.73%   84.75%   +0.01%     
==========================================
  Files          48       48              
  Lines        6140     6147       +7     
==========================================
+ Hits         5203     5210       +7     
  Misses        937      937              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tedAir tedAir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari Promt display OK https://mwpw-161334--dc--adobecom.hlx.page/acrobat/generative-ai-pdf/resume-ai on Safari. Prompts are displayed fine.

@TsayAdobe TsayAdobe merged commit e906a48 into stage Nov 4, 2024
7 of 8 checks passed
@TsayAdobe TsayAdobe deleted the MWPW-161334 branch January 15, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants