Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-161779: SUSI Link scenario when open in new tab or window #914

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

joaquinrivero
Copy link
Collaborator

Resolves: MWPW-161779

  • Adds default link in to the anchor when user use the right click to open the link in new tab or window avoiding a 404

Test URL:

https://main--dc--adobecom.hlx.page/acrobat/online
https://mwpw-161779--dc--adobecom.hlx.page/acrobat/online

Copy link

aem-code-sync bot commented Dec 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 6, 2024

Page Scores Audits Google
📱 /acrobat/online PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /acrobat/online PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (6b2c83e) to head (4bc5965).

Files with missing lines Patch % Lines
acrobat/scripts/susiAuthHandler.js 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #914      +/-   ##
==========================================
- Coverage   81.31%   81.02%   -0.29%     
==========================================
  Files          49       49              
  Lines        6429     6452      +23     
==========================================
  Hits         5228     5228              
- Misses       1201     1224      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acrobat/scripts/susiAuthHandler.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@tedAir tedAir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Chrome, FF, Safari, PASS.

@tedAir tedAir added the verified label Dec 6, 2024
@TsayAdobe TsayAdobe merged commit 847d448 into stage Dec 9, 2024
7 of 8 checks passed
@TsayAdobe TsayAdobe deleted the MWPW-161779 branch January 15, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants