-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162614: Normalize UX for field updates #100
Conversation
Refactored the editor panel in own custom element added unit tests.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
@@ -91,7 +91,7 @@ describe('Multifield', () => { | |||
).to.equal(1); | |||
}); | |||
|
|||
it('should support mas-mnemonic-field', async () => { | |||
it.only('should support mas-mnemonic-field', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.only
@yesil when you make a change to any of the fields, it does get rendered immediately in the preview but the status dot stays green (even if you move focus from the field), does not indicate any of the changes (should turn into yellow after any change and blue when saved but not yet published) . |
@yesil Also, when you add a new link to the description RTE and make a change to the text, changes are not rendered in the field (not before and not after the form save). But the changes are rendered in the card itself. This is NOT a regression but maybe is related to the other fixes so can be added |
@afmicka the link update issue is similar to MWPW-162740. Please try again let me know. |
Looks good to me |
@yesil I have removed the verified label. I checked the studio with your CSS switch branch and it is breaking the view. On hover cards are pitch black. I know you have MAS PR to support CSS change too that might handle this but then i am not sure how to proceed with merges in MAS https://mwpw-162614--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-163479--milo--adobecom#path=nala |
Refactored the editor panel in own custom element
added unit tests.
Resolve:
Test URLs: