-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-163214: M@S Studio Splash Screen #105
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
…eamline handleSelection logic
…Offer Selector Tool; enhance style with transition effect
@yesil @Axelcureno here are feedbacks w.r.t ticket AC's and issues:
3)Welcome message - i believe should display user's name fetched from IMS profile - currnetly its hardcoded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editor-panel changes are not correctly reverted yet.
studio/src/fragment-editor-base.js
Outdated
/** | ||
* @returns {boolean} Whether or not the editor was closed | ||
*/ | ||
close() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the close
method is duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
<p>${this.fragment.path}</p> | ||
|
||
return html`<div id="editor"> | ||
<editor-panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the other way around, editor-panel contains merch-card-editor.
also,editor-panel
and fragment-editor-base.js should be combined together.
e.g: https://github.com/adobecom/mas/blob/main/studio/src/editor-panel.js#L279
studio/src/mas-toolbar.js
Outdated
</div>`; | ||
} | ||
|
||
get writeActions() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the name confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to something more descriptive
studio/src/mas-toolbar.js
Outdated
Store.search.update((prev) => ({ ...prev, query: value })); | ||
} | ||
|
||
get readActions() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the name confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to something more descriptive
studio/test/utils.js
Outdated
@@ -152,3 +152,57 @@ export function initElementFromTemplate(templateId, title) { | |||
} | |||
return root; | |||
} | |||
|
|||
export const waitForElement = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this test back to editor-panel, this is testing mainly the generic editor-panel related features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
const MODEL_PATH = '/conf/mas/settings/dam/cfm/models/card'; | ||
|
||
class MerchCardEditor extends LitElement { | ||
class MerchCardEditor extends EditorPanel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editor-panel renders merch-card-editor, so the latter should not extends the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed class inheritance
#1,2,3 are fixed. Since slack ison is not available @Axelcureno left default, i'll ask that to Nick in the ticket |
Adds splash screen experience to M@S Studio.
Resolve MWPW-163214
Test URLs: