Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-163214: M@S Studio Splash Screen #105

Merged
merged 63 commits into from
Jan 10, 2025
Merged

MWPW-163214: M@S Studio Splash Screen #105

merged 63 commits into from
Jan 10, 2025

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Dec 3, 2024

Adds splash screen experience to M@S Studio.

Resolve MWPW-163214

Test URLs:

Copy link

aem-code-sync bot commented Dec 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Axelcureno Axelcureno changed the title first commit MWPW-163214: M@S Studio Splash Screen Dec 3, 2024
Copy link

aem-code-sync bot commented Dec 3, 2024

Page Scores Audits Google
📱 /studio.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /studio.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

…Offer Selector Tool; enhance style with transition effect
@Roycethan
Copy link
Collaborator

Roycethan commented Dec 24, 2024

@yesil @Axelcureno here are feedbacks w.r.t ticket AC's and issues:

  1. Status( Edits/Publish) are not updated at https://mwpw-163214--mas--adobecom.hlx.page/studio.html at first instance when user makes edits/publish in their content space and click back on "Home" sidenav option - for me i needed a browser refresh to see the recent update

  2. 'Support' menu item should be at the bottom with Slack icon that takes users to '#merch-at-scale' Slack channel when clicked
    Current:

image

Expectation:
image

3)Welcome message - i believe should display user's name fetched from IMS profile - currnetly its hardcoded
image

  1. I was not able to copy to new card/delete after selecting it (disabled select options) , am i lack any permissions or something else ?
image

cc @npeltier @3ch023

Copy link
Collaborator

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor-panel changes are not correctly reverted yet.

/**
* @returns {boolean} Whether or not the editor was closed
*/
close() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the close method is duplicated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

<p>${this.fragment.path}</p>

return html`<div id="editor">
<editor-panel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the other way around, editor-panel contains merch-card-editor.
also,editor-panel and fragment-editor-base.js should be combined together.

e.g: https://github.com/adobecom/mas/blob/main/studio/src/editor-panel.js#L279

</div>`;
}

get writeActions() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the name confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to something more descriptive

Store.search.update((prev) => ({ ...prev, query: value }));
}

get readActions() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the name confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to something more descriptive

@@ -152,3 +152,57 @@ export function initElementFromTemplate(templateId, title) {
}
return root;
}

export const waitForElement = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this test back to editor-panel, this is testing mainly the generic editor-panel related features.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Axelcureno Axelcureno requested a review from yesil January 8, 2025 00:07

const MODEL_PATH = '/conf/mas/settings/dam/cfm/models/card';

class MerchCardEditor extends LitElement {
class MerchCardEditor extends EditorPanel {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why extending from EditorPanel is needed.

I think this also resulted in the following being displayed at the top of the editor instead of the bottom.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor-panel renders merch-card-editor, so the latter should not extends the former.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed class inheritance

@Roycethan
Copy link
Collaborator

@yesil @Axelcureno here are feedbacks w.r.t ticket AC's and issues:

  1. Status( Edits/Publish) are not updated at https://mwpw-163214--mas--adobecom.hlx.page/studio.html at first instance when user makes edits/publish in their content space and click back on "Home" sidenav option - for me i needed a browser refresh to see the recent update
  2. 'Support' menu item should be at the bottom with Slack icon that takes users to '#merch-at-scale' Slack channel when clicked
    Current:
image Expectation: image

3)Welcome message - i believe should display user's name fetched from IMS profile - currnetly its hardcoded image

  1. I was not able to copy to new card/delete after selecting it (disabled select options) , am i lack any permissions or something else ?
image cc @npeltier @3ch023

#1,2,3 are fixed. Since slack ison is not available @Axelcureno left default, i'll ask that to Nick in the ticket

@Axelcureno Axelcureno merged commit 4c12a86 into main Jan 10, 2025
4 of 5 checks passed
@Axelcureno Axelcureno deleted the MWPW-163214 branch January 10, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants