MWPW-160756: Setup Nala tests for studio #116
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
@3ch023 @npeltier @yesil If MWPW-164257 gets implemented in the meantime, you can apply changes from the branch on my fork: afmicka:MWPW-160756-token that is ready for that implementation (no changes needed assuming the implementation is the same as for the OST in milo). Otherwise, you can disable the run on PRs (remove workflow file from this PR), merge this as is and be able to run tests locally (that works) and keep adding new ones. |
| }, | ||
|
|
||
| { | ||
| name: 'mas-live-firefox', |
There was a problem hiding this comment.
if we don't plan to run studio tests on FF and webkit in nearest future (which i assume we shouldn't) lets just remove them - no need to keep extra code if its unused
| # Run Playwright tests on the specific projects using root-level playwright.config.js | ||
| # This will be changed later | ||
| echo "*** Running tests on specific projects ***" | ||
| npx playwright test --config=./playwright.config.js ${TAGS} ${EXCLUDE_TAGS} --project=mas-live-chromium --project=mas-live-firefox --project=mas-live-webkit ${REPORTER} || EXIT_STATUS=$? |
There was a problem hiding this comment.
i would remove --project=mas-live-firefox --project=mas-live-webkit since we skip them later in test anyway.
nala installs infra each time for them, it makes tests longer without any gain
|
|
||
| test.beforeEach(async ({ page, browserName, baseURL }) => { | ||
| test.slow(); | ||
| test.skip( |
There was a problem hiding this comment.
this can be removed if we adjust npx command to only use chromium project
| @@ -0,0 +1,206 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
we don't have to change it in this PR but i find having both pr.run.sh and nala.run.js doing similar thing confusing, are we sure we need them both? or could be 1 script?
Adding setup for Nala tests, github workflow to run on PRs and the very first test
Resolve https://jira.corp.adobe.com/browse/MWPW-160756
Test URLs:
Before: https://main--mas--adobecom.aem.live/studio.html
After: https://MWPW-160756--mas--adobecom.aem.live/studio.html