MWPW-149125 and MWPW-147035 #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2024 13:09
…odals for mobile users only
… tab within the modal
|
yesil
reviewed
Jun 28, 2024
| @@ -370,7 +374,9 @@ export class MerchTwpD2P extends LitElement { | |||
| } | |||
|
|
|||
| get preselectedCardId() { | |||
| const preselectedCardIds = parseState()['select-cards']?.split(',').reduce((res, item) => { | |||
| const params = new URLSearchParams(window.location.search); | |||
There was a problem hiding this comment.
we should not use the search params but hash.
|
also @bozojovicic we should have one PR / commit per ticket |
|
back to backlog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are 2 TWP tickets reported long time ago but I could not implement them before TWP code in Milo is merged to Stage. MWPW-147035 is also blocked by one bug in TWP in Milo code (Card title not displayed) but I will provide the fix for that bug in Milo PR after this PR is merged.
Fix # MWPW-149125 Suppress Stock Checkbox on all modals for mobile users only
Fix # MWPW-147035 Ability to deeplink into a card or tab within the modal
Test URLs: