Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "MWPW-141119: Change default pricing for Africa site to fix broken prices/promos"" #21

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Revert "Revert "MWPW-141119: Change default pricing for Africa site to fix broken prices/promos"" #21

merged 4 commits into from
Jul 16, 2024

Conversation

rahulgupta999
Copy link
Collaborator

@rahulgupta999 rahulgupta999 commented Jul 3, 2024 •
edited
Loading

@rahulgupta999 rahulgupta999 requested a review from 3ch023 July 3, 2024 13:59
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 3, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@rahulgupta999 rahulgupta999 requested review from yesil and npeltier July 3, 2024 14:05
@rahulgupta999 rahulgupta999 added VALIDATED IN MILO Means QA has added the "Verified" label in Milo and removed UNDER MILO VALIDATION (do not merge yet) labels Jul 8, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to revert-10-revert-3-MWPW-141119 July 10, 2024 14:12 Inactive
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 10, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to revert-10-revert-3-MWPW-141119 July 12, 2024 05:06 Inactive
@rahulgupta999 rahulgupta999 added UNDER MILO VALIDATION (do not merge yet) and removed VALIDATED IN MILO Means QA has added the "Verified" label in Milo labels Jul 16, 2024
@adgaurgit adgaurgit added VALIDATED IN MILO Means QA has added the "Verified" label in Milo and removed UNDER MILO VALIDATION (do not merge yet) labels Jul 16, 2024
npeltier
npeltier approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@3ch023 3ch023 merged commit 6912c83 into main Jul 16, 2024
4 of 5 checks passed
@rahulgupta999 rahulgupta999 deleted the revert-10-revert-3-MWPW-141119 branch July 16, 2024 09:46
@3ch023 3ch023 mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirafedas mirafedas mirafedas approved these changes

@3ch023 3ch023 3ch023 approved these changes

@npeltier npeltier npeltier approved these changes

@yesil yesil Awaiting requested review from yesil

Assignees
No one assigned
Labels
bug Something isn't working VALIDATED IN MILO Means QA has added the "Verified" label in Milo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rahulgupta999 @npeltier @3ch023 @mirafedas @adgaurgit