adjust decorate and marquee anchors to hopefully pass tests

adobecom · Nov 6, 2024 · 2cbb145 · 2cbb145
1 parent a8061bc
commit 2cbb145
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/libs/blocks/marquee-anchors/marquee-anchors.js b/libs/blocks/marquee-anchors/marquee-anchors.js
@@ -78,7 +78,7 @@ export default function init(el) {
   const emptyLinkRows = links.querySelectorAll(':scope > div:not([class])');
   if (emptyLinkRows[0]) emptyLinkRows[0].classList.add('links-header');
   if (emptyLinkRows[1]) emptyLinkRows[1].classList.add('links-footer', 'body-s');
-  decorateBlockText(emptyLinkRows[0], blockTypeSizes.default.xsmall);
+  if (emptyLinkRows[0]) decorateBlockText(emptyLinkRows[0], blockTypeSizes.default.xsmall);
 
   const anchors = el.querySelectorAll('.anchor-link');
   if (anchors.length) decorateAnchors(anchors);

diff --git a/libs/utils/decorate.js b/libs/utils/decorate.js
@@ -73,9 +73,8 @@ function elContainsText(el) {
 }
 
 export function decorateBlockText(el, config = ['m', 's', 'm'], type = null) {
-  if (!el) return;
-  let headings = el.querySelectorAll('h1, h2, h3, h4, h5, h6');
   if (!el.classList.contains('default')) {
+    let headings = el?.querySelectorAll('h1, h2, h3, h4, h5, h6');
     if (headings) {
       if (type === 'hasDetailHeading' && headings.length > 1) headings = [...headings].splice(1);
       headings.forEach((h) => h.classList.add(`heading-${config[0]}`));
@@ -86,7 +85,7 @@ export function decorateBlockText(el, config = ['m', 's', 'm'], type = null) {
       }
     }
     const bodyStyle = `body-${config[1]}`;
-    const emptyEls = el.querySelectorAll(':is(p, ul, ol, div):not([class])');
+    const emptyEls = el?.querySelectorAll(':is(p, ul, ol, div):not([class])');
     if (emptyEls.length) {
       [...emptyEls].filter(elContainsText).forEach((e) => e.classList.add(bodyStyle));
     } else if (!el.classList.length && elContainsText(el)) {