fixed an issue where firefox treats position fixed as position absolute

adobecom · Jan 7, 2025 · 376f378 · 376f378
1 parent 204cb8b
commit 376f378
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/libs/blocks/global-navigation/global-navigation.js b/libs/blocks/global-navigation/global-navigation.js
@@ -1147,7 +1147,7 @@ class Gnav {
             // at this point by calling disableMobileScroll
             if (popup && this.isLocalNav()) {
               const y = Math.abs(parseInt(document.body.style.top, 10));
-              popup.style.top = `calc(${y || 0}px - var(--feds-height-nav) - 1px)`;
+              popup.style = `top: calc(${y || 0}px - var(--feds-height-nav))`;
             }
             makeTabActive(popup);
           } else if (isDesktop.matches && this.newMobileNav && isSectionMenu) {

diff --git a/libs/blocks/global-navigation/utilities/utilities.js b/libs/blocks/global-navigation/utilities/utilities.js
@@ -5,6 +5,7 @@ import {
 import { getFederatedContentRoot, getFederatedUrl, getFedsPlaceholderConfig } from '../../../utils/federated.js';
 import { processTrackingLabels } from '../../../martech/attributes.js';
 import { replaceText } from '../../../features/placeholders.js';
+import { PERSONALIZATION_TAGS } from '../../../features/personalization/personalization.js';
 
 loadLana();
 
@@ -414,11 +415,13 @@ export const closeAllTabs = (tabs, tabpanels) => {
 };
 
 export const disableMobileScroll = () => {
+  if (!PERSONALIZATION_TAGS.safari()) return;
   document.body.style.top = `-${window.scrollY}px`;
   document.body.classList.add('disable-ios-scroll');
 };
 
 export const enableMobileScroll = () => {
+  if (!PERSONALIZATION_TAGS.safari()) return;
   if (!document.body.style.top) return;
   const y = Math.abs(parseInt(document.body.style.top, 10));
   if (Number.isNaN(y)) return;