Skip to content

Commit

Permalink
fix comment messaging
Browse files Browse the repository at this point in the history
  • Loading branch information
John Pratt committed Jan 16, 2025
1 parent 1c6c92f commit 3a1b9eb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions nala/features/personalization/target-on.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ test(`${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => {
await expect(marquee.headingXL).toHaveText('Heading XL Marquee standard medium left');
});

await test.step('step-2: verify default test page', async () => {
await test.step('step-2: verify metadata test page', async () => {
console.info(`[Test Page]: ${metadataURL}`);
await page.goto(metadataURL);
await expect(marquee.headingXL).toHaveText('Target is running');

Check failure on line 27 in nala/features/personalization/target-on.test.js

View workflow job for this annotation

GitHub Actions / Running Nala E2E UI Tests (20.x)

[milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests 

  1) [milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests,@targeton0 @smoke @regression @milo  › step-2: verify metadata test page 
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.marquee').first().locator('.heading-xl').first()
    Expected string: "Target is running"
    Received string: "Heading XL Marquee standard medium left"
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.marquee').first().locator('.heading-xl').first()
      -   locator resolved to <h2 class="heading-xl" id="heading-xl-marquee-standard-medium-left">…</h2>
      -   unexpected value "Heading XL Marquee standard medium left"


      25 |     console.info(`[Test Page]: ${metadataURL}`);
      26 |     await page.goto(metadataURL);
    > 27 |     await expect(marquee.headingXL).toHaveText('Target is running');
         |                                     ^
      28 |   });
      29 |
      30 |   await test.step('step-3: verify parameter test page', async () => {

        at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:27:37
        at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:24:3

Check failure on line 27 in nala/features/personalization/target-on.test.js

View workflow job for this annotation

GitHub Actions / Running Nala E2E UI Tests (20.x)

[milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests 

  1) [milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests,@targeton0 @smoke @regression @milo  › step-2: verify metadata test page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.marquee').first().locator('.heading-xl').first()
    Expected string: "Target is running"
    Received string: "Heading XL Marquee standard medium left"
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.marquee').first().locator('.heading-xl').first()
      -   locator resolved to <h2 class="heading-xl" id="heading-xl-marquee-standard-medium-left">…</h2>
      -   unexpected value "Heading XL Marquee standard medium left"


      25 |     console.info(`[Test Page]: ${metadataURL}`);
      26 |     await page.goto(metadataURL);
    > 27 |     await expect(marquee.headingXL).toHaveText('Target is running');
         |                                     ^
      28 |   });
      29 |
      30 |   await test.step('step-3: verify parameter test page', async () => {

        at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:27:37
        at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:24:3
});

await test.step('step-3: verify default test page', async () => {
await test.step('step-3: verify parameter test page', async () => {
console.info(`[Test Page]: ${parameterURL}`);
await page.goto(parameterURL);
await expect(marquee.headingXL).toHaveText('Target is running');
Expand Down

0 comments on commit 3a1b9eb

Please sign in to comment.