MWPW-144575: Modal-Iframe for apps-whats-included is broken for Deskt…

…op resolutions (#2016) fixed CSS selector commerce-frame section and fragment
adobecom · Mar 15, 2024 · 52bb962 · 52bb962
1 parent 56bbeb1
commit 52bb962
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/libs/blocks/merch/merch.css b/libs/blocks/merch/merch.css
@@ -59,6 +59,7 @@ a[is='checkout-link'] > span {
 }
 
 #checkout-link-modal iframe {
+  height: 100%;
   flex: 1;
 }
 

diff --git a/libs/blocks/modal/modal.css b/libs/blocks/modal/modal.css
@@ -200,7 +200,8 @@
   }
 
   .dialog-modal.commerce-frame > .fragment,
-  .dialog-modal.commerce-frame > .section {
+  .dialog-modal.commerce-frame > .section,
+  .dialog-modal.commerce-frame > .fragment > .section {
     height: 100vh;
   }
 }
@@ -221,7 +222,8 @@
   }
 
   .dialog-modal.commerce-frame > .fragment,
-  .dialog-modal.commerce-frame > .section {
+  .dialog-modal.commerce-frame > .section,
+  .dialog-modal.commerce-frame > .fragment > .section {
     height: 100%;
   }
 

diff --git a/libs/blocks/modal/modal.merch.js b/libs/blocks/modal/modal.merch.js
@@ -60,7 +60,7 @@ export function adjustStyles({ dialog, iframe }) {
   if (isAutoHeightAdjustment) {
     dialog.classList.add('height-fit-content');
   } else {
-    iframe.style.height = '100vh';
+    iframe.style.height = '100%';
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,6 +59,7 @@ a[is='checkout-link'] > span { @@
     }
     #checkout-link-modal iframe {
+      height: 100%;
       flex: 1;
     }
@@ Expand Down @@