PR feedback

adobecom · Jul 31, 2024 · c7a5396 · c7a5396
1 parent b7f8db4
commit c7a5396
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/libs/blocks/editorial-card/editorial-card.css b/libs/blocks/editorial-card/editorial-card.css
@@ -160,8 +160,7 @@
   display: flex;
   align-items: center;
   justify-content: right;
-  column-gap: var(--spacing-s);
-  row-gap: var(--spacing-xs);
+  gap: var(--spacing-xs) var(--spacing-s);
   flex-flow: wrap;
   flex-direction: row;
 }
@@ -230,10 +229,7 @@
   max-height: unset;
 }
 
-.editorial-card.media-square .media-area .milo-video,
-.editorial-card.media-wide .media-area .milo-video,
-.editorial-card.media-standard .media-area .milo-video,
-.editorial-card.media-tall .media-area .milo-video {
+.editorial-card:is(.media-square, .media-wide, .media-standard, .media-tall) .media-area .milo-video {
   height: auto;
   padding: 0;
 }

diff --git a/libs/blocks/editorial-card/editorial-card.js b/libs/blocks/editorial-card/editorial-card.js
@@ -47,7 +47,7 @@ const decorateForeground = async (el, rows) => {
       await decorateLockupFromContent(row);
     } else if (i === (rows.length - 1)) {
       row.classList.add('footer');
-      if (row.textContent.trim() === '') row.classList.add('empty');
+      if (!row.textContent.trim()) row.classList.add('empty');
     } else {
       row.classList.add('extra-row');
     }

diff --git a/libs/blocks/marquee/marquee.css b/libs/blocks/marquee/marquee.css
@@ -301,7 +301,6 @@
 }
 
 .marquee.split .icon-area img {
-  height: auto;
   max-height: var(--icon-size-l);
   max-width: 275px;
   object-fit: contain;
@@ -449,6 +448,10 @@
     padding: var(--spacing-xl) 0;
   }
 
+  html[dir="rtl"] .marquee.split .foreground.container {
+    flex-direction: row-reverse;
+  }
+
   .marquee.split .foreground.container .text {
     max-width: calc(50% - var(--grid-column-width));
   }
@@ -484,6 +487,7 @@
     max-width: 212px;
   }
 
+
   .marquee.split.row-reversed .foreground.container {
     justify-content: flex-end;
   }
@@ -492,14 +496,6 @@
     justify-content: flex-start;
   }
 
-  html[dir="rtl"] .marquee.support-rtl.split .foreground.container {
-    flex-direction: row;
-  }
-
-  html[dir="rtl"] .marquee.support-rtl.split.row-reversed .foreground.container {
-    flex-direction: row-reverse;
-  }
-
   .marquee.split .asset img,
   .marquee.split.small .asset img,
   .marquee.split.large .asset img,