Skip to content

Commit

Permalink
[MWPW-156187][Milo Catalog Accessibility] "more actions" on catalog c…
Browse files Browse the repository at this point in the history
…ards not accessible (#3082)

* Fixing issue: "more actions" on catalog cards not accessible

* added test

* Test updates.

* Remove the focus event effect on card mouseleave event.

* Removed aria-label for "Violation: Ensure ARIA attributes are not prohibited for an element's role"

* Added text and role for the action menu
  • Loading branch information
seanchoi-dev authored Oct 30, 2024
1 parent 22ac880 commit edff299
Show file tree
Hide file tree
Showing 5 changed files with 150 additions and 57 deletions.
2 changes: 1 addition & 1 deletion libs/blocks/merch-card/merch-card.js
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ export default async function init(el) {
merchCard.append(
createTag(
'div',
{ slot: 'action-menu-content' },
{ slot: 'action-menu-content', tabindex: '0' },
actionMenuContent.innerHTML,
),
);
Expand Down
Loading

0 comments on commit edff299

Please sign in to comment.