Sync down to stage #1147

auniverseaway · 2023-08-22T22:12:16Z

No description provided.

Co-authored-by: Blaine Gunn <gunn@adobe.com>

* Skip failing tests and use a custom reporter * Unskip and fix failing tests --------- Co-authored-by: Chris Millar <cmillar@adobe.com>

* Initial support for Jarvis * Add support for Jarvis chat * Jarvis tests * Jarvis support * first round of feedback * Remove custom config * Update libs/features/jarvis-chat.js Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * feedback round 3 * implement feedback --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

Fixed taxonomy categry default. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

* MWPW-131015: Fix spectrum style issues and improve the layout. * MWPW-131015: Restore OST urls * MWPW-131015: Restore merch.js * MWPW-131015: fix price style in OST * Update OST version * Add token parameter support to bypass IMS wait for IMS ready in order to prevent sign-in attempt too early. * comment token section. * remove gnav hiding logic via css and use metadata for the purpose. --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

* Updating actions to trigger aio services from fg admin console * Adding status buttons for fg and promote actions. * Updating floodgate UI status table with AIO status fetch calls * Moving reused functions to fg utils js * Renaming functions - all AIO calls are named as actions * Adding description/message column to project status table. * Reverting unused constants and imports. Fixing fgRoot path for promote actions --------- Co-authored-by: Sekhar <sirivuri@adobe.com>

* MWPW-126707: Global navigation lana logs * Address feedback --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

* MWPW-130474: remove placeholder syntax from price links * MWPW-130474: added required css file * unit test fix * Update CODEOWNERS * Update CODEOWNERS --------- Co-authored-by: Axel Cureno Basurto <axel@adobe.com> Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

* Initial support for Jarvis * Add support for Jarvis chat * Jarvis tests * Jarvis support * first round of feedback * Remove custom config * Update libs/features/jarvis-chat.js Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> * feedback round 3 * implement feedback * Serve non-critical features from delayed * import and execute delayed * implement feedback --------- Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Preflight UX Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

MWPW-129907 Blog Article Typogrpahy Corrections * Fixes typography getting cut off in Featured Article block * Fixes typography getting cut off in Article Card block Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <rclayton@adobe.com>

This fixes a bug where Blog tags were getting stripped down to the point they no longer matched what was listed in the related taxonomy file. Causing tags to not render on the page. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-131664: icrease merch resilience to errors * fix(#748): icrease merch resilience to errors * fix test --------- Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

* Let region nav to use prefix instead content root. * Removing the config.contentRoot for fallback case.

- Added Promote Publish Option - Passing this to Promote Action Co-authored-by: armohamm <armohamm@adobe.com>

* Highlight expanded navigation menu on mobile * implement feedback * implement feedback --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

…tion variant (#757) unset min-height on bg image for notification variant Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

MWPW-131637: imporve OST for small screens Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

…r and fgRoot… (#781) Removing duplicated projectRoot param and using rootFolder and fgRootFolder for updating copy/promote status. Co-authored-by: Sekhar <sirivuri@adobe.com>

Co-authored-by: Honwai Wong <honstar.wong@gmail.com> Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.macromedia.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MBP.attlocal.net>

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local> Co-authored-by: Elaine Borges <62952234+elaineskpt@users.noreply.github.com> Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

MWPW-129917 - Milo Aside block enhancements 1. Product icon stack in large and medium split asides. Desktop mode will have 2 columns and mobile and tablet will have stack in a row. Author can add only icon, linked icon, icon with plain text or linked text. 2. Static links to inherit link color same as the text. Adding style option in section metadata to change plain link color and inherit the same color as text. 3. Option to set the aspect ratio of image/media for large and medium split asides. 4. Add an avatar icon for aside having contributor bio. Add a bio variation for aside that converts icon-area to avatar image. 5. Aside center variation. No side image or media. Large variation has icon and supplemental text, Medium variation has icon or supplemental text, Small variation does not have either icon or supplemental text. Icon max sizes differ as per the XD for screen sizes. 6. Support video in background and foreground for standard and split aside. 7. Add a 24px padding before supplemental text. 8. Spacing in Asides - For all aside (split and standard) the spacing is 40px between text and image, and 80px from margin. For split aside the image does not have any spacing from edge. --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

* MWPW-133733: add promo support to OST links * MWPW-133733: removed console.logs * MWPW-133733: removed console.logs * MWPW-133733: opens OST with right promotion code * MWPW-133733: OST: add test case for searchParams

* Do not lana log IMS timeouts for the global nav * Always attempt to show the user sign in button, even on IMS timeouts

initial Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>

Co-authored-by: Narcis Radu <github@narcisradu.ro>

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>

…ame modal. (#1131) * geo routing pop up is displayed behind the iframe modal * added modal specificity to commerce dialog modal * geo routing popup overlaps commerce frame fixed with z-index * z-index changed to 103 --------- Co-authored-by: Narcis Radu <github@narcisradu.ro>

* MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 symbol id with hyphen --------- Co-authored-by: Puru <doreswam@adobe.com>

* action item and action scroller blocks/tests * update scroller css default gap * fix selector in action scroller test * remove unneeded moz vendor prefixes * remove img size attrs and simplify border property action scroller * simplify link decorating attrs * use array spread instead of from * min height for float icon * handle different image types for float icon * remove unneeded text selector * simplify float variant checks * fix tests and final cleanup

aem-code-sync · 2023-08-22T22:12:18Z

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

aem-code-sync · 2023-08-22T22:12:46Z

Page	Scores	Audits	Google
/
/tools/library
/drafts/cpeyer/pers/pers-ref

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

libs/blocks/tabs/tabs.js|171 col 11| 'rows' is already declared in the upper scope on line 103 column 9.
libs/blocks/tabs/tabs.js|181 col 9| Use array destructuring.
libs/hooks/useHover.js|39 col 5| React Hook useEffect has missing dependencies: 'mouseOutType' and 'ref'. Either include them or remove the dependency array. Mutable values like 'ref.current' aren't valid dependencies because mutating them doesn't re-render the component.
libs/ui/controls/CopyBtn.js|2 col 26| 'useEffect' is defined but never used.
libs/ui/controls/MultiField.js|84 col 6| React Hook useEffect has missing dependencies: 'name' and 'parentIndex'. Either include them or remove the dependency array. If 'setFieldValues' needs the current value of 'parentIndex', you can also switch to useReducer instead of useState and read 'parentIndex' in the reducer.
libs/ui/controls/MultiField.js|95 col 6| React Hook useEffect has missing dependencies: 'addMultifieldChangeListener' and 'children'. Either include them or remove the dependency array.
libs/ui/controls/formControls.js|16 col 6| React Hook useEffect has missing dependencies: 'validateInput' and 'value'. Either include them or remove the dependency array.
libs/ui/controls/formControls.js|58 col 6| React Hook useEffect has missing dependencies: 'validateInput' and 'value'. Either include them or remove the dependency array.
libs/utils/inline.js|3 col 1| Prefer default export.
libs/utils/lana.js|53 col 5| 'log' was used before it was defined.
libs/utils/lana.js|57 col 5| Assignment to function parameter 'msg'.
libs/utils/lana.js|59 col 7| Assignment to function parameter 'msg'.
libs/utils/lana.js|86 col 60| Unexpected console statement.
libs/utils/lana.js|93 col 11| Unexpected console statement.
libs/utils/lana.js|98 col 7| Function 'log' expected no return value.
test/blocks/commerce/commerce.test.js|90 col 11| 'offerDetailsWrapper' is assigned a value but never used.
test/blocks/global-navigation/keyboard/keyboard.test.js|406 col 43| Unexpected use of continue statement.
test/blocks/global-navigation/keyboard/keyboard.test.js|417 col 43| Unexpected use of continue statement.
test/blocks/global-navigation/keyboard/keyboard.test.js|428 col 43| Unexpected use of continue statement.
test/blocks/global-navigation/keyboard/keyboard.test.js|439 col 43| Unexpected use of continue statement.
test/blocks/tabs/tabs.test.js|1 col 20| 'sendMouse' is defined but never used.
tools/utils/utils.js|17 col 10| Prefer default export.

github-actions · 2023-08-22T22:13:09Z

build/htm-preact-debug.js

@@ -1,9 +1,13 @@
 import 'preact/debug';


🚫 [eslint] <import/extensions> _{reported by reviewdog 🐶}
Missing file extension "js" for "preact/debug"

github-actions · 2023-08-22T22:13:09Z

build/htm-preact-debug.js

@@ -1,9 +1,13 @@
 import 'preact/debug';
 import { h, Component, createContext, createRef, render } from 'preact';
 import { signal } from '@preact/signals';
-import { useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId } from 'preact/hooks';
+import {
+  useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId,


🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 154. Maximum allowed is 100.

github-actions · 2023-08-22T22:13:09Z

build/htm-preact-debug.js

-import { useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId } from 'preact/hooks';
+import {
+  useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId,
+} from 'preact/hooks';


🚫 [eslint] <import/extensions> _{reported by reviewdog 🐶}
Missing file extension "js" for "preact/hooks"

github-actions · 2023-08-22T22:13:09Z

build/htm-preact-debug.js

 import htm from 'htm';

 const html = htm.bind(h);

-export { h, html, signal, render, Component, createContext, createRef, useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId };
+export {
+  h, html, signal, render, Component, createContext, createRef, useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId,


🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 216. Maximum allowed is 100.

github-actions · 2023-08-22T22:13:09Z

build/htm-preact.js

@@ -2,9 +2,13 @@

 import { h, Component, createContext, createRef, render } from 'preact';
 import { signal } from '@preact/signals';
-import { useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId } from 'preact/hooks';
+import {
+  useState, useReducer, useEffect, useLayoutEffect, useRef, useImperativeHandle, useMemo, useCallback, useContext, useDebugValue, useErrorBoundary, useId,


🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 154. Maximum allowed is 100.

github-actions · 2023-08-22T22:13:12Z

libs/blocks/tabs/tabs.js

+    const images = block.querySelectorAll('img[loading="lazy"]');
+		  images.forEach((img) => {
+		    /* c8 ignore next */
+		    img.removeAttribute('loading');


🚫 [eslint] <no-tabs> _{reported by reviewdog 🐶}
Unexpected tab character.

github-actions · 2023-08-22T22:13:12Z

libs/blocks/tabs/tabs.js

+    const images = block.querySelectorAll('img[loading="lazy"]');
+		  images.forEach((img) => {
+		    /* c8 ignore next */
+		    img.removeAttribute('loading');


🚫 [eslint] <no-mixed-spaces-and-tabs> _{reported by reviewdog 🐶}
Mixed spaces and tabs.

github-actions · 2023-08-22T22:13:12Z

libs/blocks/tabs/tabs.js

+		  images.forEach((img) => {
+		    /* c8 ignore next */
+		    img.removeAttribute('loading');
+		  });


🚫 [eslint] <no-tabs> _{reported by reviewdog 🐶}
Unexpected tab character.

github-actions · 2023-08-22T22:13:12Z

libs/blocks/tabs/tabs.js

+		  images.forEach((img) => {
+		    /* c8 ignore next */
+		    img.removeAttribute('loading');
+		  });


🚫 [eslint] <no-mixed-spaces-and-tabs> _{reported by reviewdog 🐶}
Mixed spaces and tabs.

github-actions · 2023-08-22T22:13:13Z

libs/blocks/tabs/tabs.js

  // Tab Sections
  const allSections = Array.from(rootElem.querySelectorAll('div.section'));
-  allSections.forEach((e) => {
+  allSections.forEach((e, i) => {


🚫 [eslint] <no-unused-vars> _{reported by reviewdog 🐶}
'i' is defined but never used.

Blainegunn and others added 30 commits May 18, 2023 10:09

MWPW-130142 (#725)

69ebdaf

Co-authored-by: Blaine Gunn <gunn@adobe.com>

Fix two failing tests and add a custom test reporter (#724)

5a79116

* Skip failing tests and use a custom reporter * Unskip and fix failing tests --------- Co-authored-by: Chris Millar <cmillar@adobe.com>

MWPW-131381 Move flags to sharepoint (#737)

1df50e1

MWPW-129907 - Blog Migration (#741)

d272636

Fixed taxonomy categry default. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

MWPW-131263: preview call update for promote

d3a13e7

Address TODOs (#736)

6802408

Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Ensure the global navigation is displayed on top of page content (#734)

f358610

Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

MWPW-126707: Global navigation lana logs (#743)

9f3e63c

* MWPW-126707: Global navigation lana logs * Address feedback --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

minor: Preflight UX (#758)

7e4c91a

Preflight UX Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Provide default id for privacy (#764)

fa1b677

FEDS Gnav critical bug squashing (#745)

d5ab9f2

Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>

[MWPW-131242] Use dark color for hamburger button (#767)

bb1a52c

MWPW-131666: update to absolute url (#768)

efd4868

Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Use the default IMS scope if one is not provided by consumers (#766)

75c2208

MWPW-129907 Blog Tags (#762)

6dba925

This fixes a bug where Blog tags were getting stripped down to the point they no longer matched what was listed in the related taxonomy file. Causing tags to not render on the page. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <rclayton@adobe.com>

MWPW-131266: Update FG project details (#774)

8befe08

MWPW-131664: increase merch resilience to errors (#765)

bf2216d

* MWPW-131664: icrease merch resilience to errors * fix(#748): icrease merch resilience to errors * fix test --------- Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

Let region nav to use prefix instead content root. (#770)

50eaa63

* Let region nav to use prefix instead content root. * Removing the config.contentRoot for fallback case.

MWPW-124580 - Promote Publish Milo changes (#782)

0d44d58

- Added Promote Publish Option - Passing this to Promote Action Co-authored-by: armohamm <armohamm@adobe.com>

Highlight expanded navigation menu on mobile (#763)

31eeedc

* Highlight expanded navigation menu on mobile * implement feedback * implement feedback --------- Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

[MWPW-131397] Unset min-height on Aside background image for notifica…

a360189

…tion variant (#757) unset min-height on bg image for notification variant Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

MWPW-131637: improve OST for small screens (#779)

7ec6582

MWPW-131637: imporve OST for small screens Co-authored-by: Honwai Wong <honstar.wong@gmail.com>

MWPW-125482 Overriding text flow direction via metatag (#777)

4d8a0bc

MWPW-128694 Removing duplicated projectRoot param and using rootFolde…

d8fa6da

…r and fgRoot… (#781) Removing duplicated projectRoot param and using rootFolder and fgRootFolder for updating copy/promote status. Co-authored-by: Sekhar <sirivuri@adobe.com>

tamanyan and others added 26 commits August 15, 2023 19:55

MWPW-129730 - Word wrap function (#727)

e3462a0

Co-authored-by: Honwai Wong <honstar.wong@gmail.com> Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>

Mwpw 132793 Icon and Quotes Blocks RTL Alignment Issue. (#959)

3e572f6

Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

MWPW-128325: authoring dialog changes for hiding ctas using tags (#1103)

e661c8f

Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.macromedia.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MBP.attlocal.net>

Play video on hover (#1106)

e0e58a0

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local> Co-authored-by: Elaine Borges <62952234+elaineskpt@users.noreply.github.com> Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

[MWPW-134861] Remove loading of App Launcher (#1113)

4fb5e17

MWPW-131211 Personalization Entitlement Support (#1104)

51e9c24

Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com>

MWPW-133055 Sticky bottom section functionality enhancement (#1080)

6420697

Run dispatch workflow only for adobecom/milo (#1119)

bca91e1

MWPW-135191 Hide caas link that has a query param (#1114)

84a1801

MWPW-134481 - Add section xxs spacing variant (#1116)

c471909

MWPW-131211 Clear entitlements from localStorage on logout (#1122)

b2e40bd

MWPW-133733: add promo support to OST links (#1120)

6df25bd

* MWPW-133733: add promo support to OST links * MWPW-133733: removed console.logs * MWPW-133733: removed console.logs * MWPW-133733: opens OST with right promotion code * MWPW-133733: OST: add test case for searchParams

Do not lana log IMS timeouts for the global nav (#1127)

da47038

* Do not lana log IMS timeouts for the global nav * Always attempt to show the user sign in button, even on IMS timeouts

fix video loading issue in figure block (#1124)

ac14708

mep-add-marker-data-fix (#1125)

67fad72

initial Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com>

MWPW-135276 Fix video selector (#1129)

ab46221

add optional chaining operator to get hash value for hoverplay (#1130)

dc7f791

MWPW-133754 - Support structured data API for SEO (#1115)

9b4100e

interlinks in marquee anchor block fixed (#1132)

44e5829

Co-authored-by: Narcis Radu <github@narcisradu.ro>

fix issue of video not loading in figure block (#1134)

6eba19b

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>

MWPW-134677 Fix aside mobile spacing (#1135)

3f9f510

MWPW-135413 Support multiple link features (#1142)

b2de3ee

auniverseaway merged commit d435619 into stage Aug 22, 2023

github-actions bot reviewed Aug 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync down to stage #1147

Sync down to stage #1147

auniverseaway commented Aug 22, 2023

aem-code-sync bot commented Aug 22, 2023

aem-code-sync bot commented Aug 22, 2023

github-actions bot left a comment

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

github-actions bot Aug 22, 2023

Sync down to stage #1147

Sync down to stage #1147

Conversation

auniverseaway commented Aug 22, 2023

aem-code-sync bot commented Aug 22, 2023

aem-code-sync bot commented Aug 22, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment

github-actions bot Aug 22, 2023

Choose a reason for hiding this comment