MWPW-142130: update the source of merch card name #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yesil
added
run-nala
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 95.68% 95.65% -0.04%
==========================================
Files 159 159
Lines 41244 41150 -94
==========================================
- Hits 39465 39361 -104
- Misses 1779 1789 +10 ☔ View full report in Codecov by Sentry. |
VKniaz
approved these changes
Feb 15, 2024
Axelcureno
approved these changes
Feb 15, 2024
vladen
approved these changes
Feb 16, 2024
Roycethan
added
verified
honstar
approved these changes
Feb 22, 2024
yesil
added a commit
that referenced
this pull request
Feb 26, 2024
yesil
added a commit
to yesil/milo
that referenced
this pull request
Mar 4, 2024
…1927) Revert "MWPW-142130: update the source of merch card name (adobecom#1883)" This reverts commit f5e68ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-142130
Includes: https://git.corp.adobe.com/wcms/tacocat.js/pull/536
As per the discussion, the source of card name has been moved to the tags section. Card name and card title can be used as a sort key for sorting cards in different filters in
merch-cardsblock.Test URLs:
CC Test URLs:
Catalog page:
https://main--cc--adobecom.hlx.live/drafts/ilyas/catalog?milolibs=mwpw-142130--milo--yesil
Test page:
https://main--cc--adobecom.hlx.live/drafts/ilyas/merch-cards-sorting?milolibs=mwpw-142130--milo--yesil