Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-146268 - [Milo - Tabs] Pill dark/light support #2132

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Apr 10, 2024

Pill tab-list styles should support light and dark themes. Currently it doesn't work with dark theme.

  • Removes background : unset on tab.pill variant

Resolves: MWPW-146268

Test URLs:

@Sartxi Sartxi added bug Something isn't working needs-verification PR requires E2E testing by a reviewer labels Apr 10, 2024
Copy link
Contributor

aem-code-sync bot commented Apr 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Apr 10, 2024

Page Scores Audits Google
/drafts/sarchibeque/pill-tabs?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (1f48cda) to head (5238490).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2132      +/-   ##
==========================================
+ Coverage   96.35%   96.41%   +0.06%     
==========================================
  Files         165      165              
  Lines       43534    43534              
==========================================
+ Hits        41947    41975      +28     
+ Misses       1587     1559      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmparrish ryanmparrish added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Apr 10, 2024
@skumar09 skumar09 added the run-nala Run Nala Test Automation against PR label Apr 10, 2024
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@Blainegunn Blainegunn merged commit 8c96f74 into stage Apr 11, 2024
22 checks passed
@Blainegunn Blainegunn deleted the sarchibeque/mwpw-146268-pill-tab-dark branch April 11, 2024 19:48
@Blainegunn
Copy link
Contributor

lovely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants