MWPW-146263 - [Bulk Publish v2] Job Info UI #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sartxi
added
new-feature
Sartxi
requested review from
auniverseaway,
ryanmparrish,
rgclayton and
elan-tbx
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
Looking good Sean! If doing multiple jobs, having the most recent job be at the top of the list. Otherwise I have to scroll a bunch to get to my most recent job links. Or maybe each job batch can be collapsible/expandable?
|
rgclayton
approved these changes
Apr 23, 2024
elan-tbx
approved these changes
Apr 23, 2024
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2158 +/- ##
==========================================
- Coverage 96.15% 95.67% -0.49%
==========================================
Files 165 165
Lines 43591 43534 -57
==========================================
- Hits 41916 41651 -265
- Misses 1675 1883 +208 ☔ View full report in Codecov by Sentry. |
elan-tbx
added
verified
ryanmparrish
approved these changes
Apr 30, 2024
Blainegunn
added a commit
that referenced
this pull request
May 2, 2024
* MWPW-147027: CTA flowing out of mini compare card (due to long strings) (#2217) * MWPW-147027: CTA flowing out of mini compare card (due to long strings) * footer fix * Update merch-card.js * Update merch-card.js * MWPW-147149: Prevent multiple download/upgrade CTAs (#2226) * MWPW-147149: Prevent multiple download links in the same marquee or merch-card * add upgrade use case. * add comment * typo fix * improve href attribute setting * commerce.js from develop * MWPW-146845 Setup Footer Promo for Localization (#2236) * MWPW-146263 - [Bulk Publish v2] Job Info UI (#2158) * add job info to job processes * add job info updates * ui dialing * finish up UI and refactored a little * update label * unit tests to support new functionality * package index jobs into one * feedback from demo * fix unit test * code cov * get full code cov * can test copy to clipboard in process component * fix tabs test * Adding additional IMS Scope for A.com Client IDs (#2249) * MWPW-146784 Add new default IMS scopes * MWPW-146784 Add new default IMS scopes --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> * MWPW-146070: Upgrade Universal Nav to Version 1.1 in Milo (#2250) * MWPW-146070: Upgrade unav to 1.1 * MWPW-146784 Add new default IMS scopes * MWPW-146784 Add new default IMS scopes --------- Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> --------- Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: sonawanesnehal3 <152426902+sonawanesnehal3@users.noreply.github.com> Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display job info such as progress, status, and give option to copy a jobs invocation ID in the Job Results Panel. Also adds error filtering and error rework functionality.
Resolves: MWPW-146263
Test URLs: