Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-147145: PEP final touches #2211

Merged
merged 1 commit into from
Apr 29, 2024
Merged

MWPW-147145: PEP final touches #2211

merged 1 commit into from
Apr 29, 2024

Conversation

robert-bogos
Copy link
Contributor

Description

This PR is addressing all the leftover TODOs from project PEP and adds more unit tests.

Related Issue

Resolves: MWPW-147145

Test URLs

Milo:

@robert-bogos robert-bogos added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Apr 25, 2024
@robert-bogos robert-bogos self-assigned this Apr 25, 2024
@robert-bogos robert-bogos requested a review from a team as a code owner April 25, 2024 19:04
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 25, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/rbogos/pep-prompt?imsClientId=fedsmilo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

overmyheadandbody
overmyheadandbody approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for moving this forward!

mokimo
mokimo approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@mokimo
Copy link
Contributor

mokimo commented Apr 26, 2024

Make sure to get the PSI check running

@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

SilviuLCF
SilviuLCF approved these changes Apr 29, 2024
View reviewed changes
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified
Testing details
https://jira.corp.adobe.com/browse/MWPW-147145

@SilviuLCF SilviuLCF added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Apr 29, 2024
@overmyheadandbody overmyheadandbody merged commit b2ddbe7 into adobecom:project-pep Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokimo mokimo mokimo approved these changes

@SilviuLCF SilviuLCF SilviuLCF approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

@narcis-radu narcis-radu narcis-radu approved these changes

Assignees

@robert-bogos robert-bogos

Labels
run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robert-bogos @mokimo @narcis-radu @overmyheadandbody @SilviuLCF