Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-147284: discard default params in merch link #2231

Merged
merged 6 commits into from
May 2, 2024
Merged

MWPW-147284: discard default params in merch link #2231

merged 6 commits into from
May 2, 2024

Conversation

yesil
Copy link
Contributor

@yesil yesil commented Apr 30, 2024 •
edited
Loading

that are generated via Offer Selector Tool(OST).

This is an authoring only fix in OST.
It has no impact on page performance.

Resolves: MWPW-147284

Test URLs:

@yesil yesil requested a review from a team as a code owner April 30, 2024 10:07
@yesil yesil added commerce needs-verification PR requires E2E testing by a reviewer labels Apr 30, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 30, 2024 •
edited
Loading

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@yesil yesil assigned Roycethan and unassigned afmicka Apr 30, 2024
@Roycethan
Copy link

Roycethan commented May 1, 2024 •
edited
Loading

Checked at https://mwpw-147284--milo--yesil.hlx.page/tools/ost
the additional parameters are stripped off from the url;
Ex:
Price:
https://milo.adobe.com/tools/ost?osi=PpnQ-UmW9NBwZwXlFw79zw2JybhvwIUwMTDYiIlu5qI&type=price
https://milo.adobe.com/tools/ost?osi=r_JXAnlFI7xD6FxWKl2ODvZriLYBoSL701Kd1hRyhe8&type=priceStrikethrough
https://milo.adobe.com/tools/ost?osi=LzMV-Ok5xsBW10pPKrRMWq7ewtZjtbOqhaPUIO7tFD0&type=priceOptical

Checkout:

https://milo.adobe.com/tools/ost?osi=PpnQ-UmW9NBwZwXlFw79zw2JybhvwIUwMTDYiIlu5qI&type=checkoutUrl&text=buy-now

https://milo.adobe.com/tools/ost?osi=LzMV-Ok5xsBW10pPKrRMWq7ewtZjtbOqhaPUIO7tFD0&type=checkoutUrl&text=start-free-trial&workflowStep=commitment

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

3ch023
3ch023 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@3ch023 3ch023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Blainegunn Blainegunn merged commit 97eb1e9 into adobecom:stage May 2, 2024
12 checks passed
@Blainegunn Blainegunn mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirafedas mirafedas mirafedas approved these changes

@vladen vladen vladen approved these changes

@3ch023 3ch023 3ch023 approved these changes

Assignees

@Roycethan Roycethan

Labels
commerce Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yesil @Roycethan @3ch023 @vladen @mirafedas @Blainegunn @afmicka