Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-147173 - Add gap below Aside notification headings #2255

Merged
merged 5 commits into from
May 8, 2024

Conversation

elan-tbx
Copy link
Contributor

@elan-tbx elan-tbx commented May 2, 2024

@elan-tbx elan-tbx added trivial PR doesn't require E2E testing by a reviewer run-nala Run Nala Test Automation against PR labels May 2, 2024
@elan-tbx elan-tbx requested a review from Sartxi as a code owner May 2, 2024 23:32
Copy link
Contributor

aem-code-sync bot commented May 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147173-aside-heading-space May 2, 2024 23:32 Inactive
Copy link
Contributor

aem-code-sync bot commented May 2, 2024

Page Scores Audits Google
/drafts/ebartholomew/aside-lg-test?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (73af8b8) to head (72c7909).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2255      +/-   ##
==========================================
- Coverage   95.71%   95.70%   -0.01%     
==========================================
  Files         166      166              
  Lines       44009    44009              
==========================================
- Hits        42124    42120       -4     
- Misses       1885     1889       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 3, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147173-aside-heading-space May 3, 2024 15:39 Inactive
libs/blocks/aside/aside.css Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147173-aside-heading-space May 8, 2024 13:41 Inactive
@milo-pr-merge milo-pr-merge bot merged commit 95ab427 into stage May 8, 2024
11 checks passed
@milo-pr-merge milo-pr-merge bot deleted the ebartholomew/MWPW-147173-aside-heading-space branch May 8, 2024 16:11
@SilviuLCF SilviuLCF self-requested a review May 9, 2024 08:10
@SilviuLCF SilviuLCF added the verified PR has been E2E tested by a reviewer label May 9, 2024
@SilviuLCF
Copy link

Verified, testing details: MWPW-147173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR trivial PR doesn't require E2E testing by a reviewer verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants