Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gbajaj swc update #2354

Merged
merged 2 commits into from
May 22, 2024
Merged

Gbajaj swc update #2354

merged 2 commits into from
May 22, 2024

Conversation

gbajaj91
Copy link
Contributor

  • Add your
  • Specific
  • Features or fixes

Resolves: MWPW-NUMBER

Test URLs:

@gbajaj91 gbajaj91 requested a review from a team as a code owner May 22, 2024 08:54
@mokimo
Copy link
Contributor

mokimo commented May 22, 2024

@gbajaj91 we usually don't open PRs to merge anything into branches, if we do (loc) that's usually the exception or to provide feedback (uar, bigger projects with milestones)

Make sure to add a meaningful description, jira, testable links if you do have a reason to open PRs to a branch.

@qiyundai
Copy link
Contributor

qiyundai commented May 22, 2024

@gbajaj91 we usually don't open PRs to merge anything into branches, if we do (loc) that's usually the exception or to provide feedback (uar, bigger projects with milestones)

Make sure to add a meaningful description, jira, testable links if you do have a reason to open PRs to a branch.

Hi Okan!

Thanks for capturing this -- I want to quickly explain our situations here:
We are experimenting with importing more Spectrum Web Components for the new Tier3 Events on Milo project. Unfortunately @gbajaj91 doesn't have the access to create his own branch on Milo so we worked around it by having him raising PR to a branch I created to do the testings we needed while waiting for the access to be granted.

@qiyundai qiyundai merged commit 2f43b64 into adobecom:ecc May 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants