Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-148437 [MILO][MEP] Placeholders don't work if you qualify for default and override with mep= #2439

Merged
merged 14 commits into from
Jun 11, 2024
Merged

MWPW-148437 [MILO][MEP] Placeholders don't work if you qualify for default and override with mep= #2439

Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c3b1675
replace overridePersonalizationVariant function
markpadbe Jun 5, 2024
06d62a1
Fix chaining
markpadbe Jun 5, 2024
ee8a2f5
Move parseMepParam
markpadbe Jun 5, 2024
c027c7d
Merge branch 'stage' into mepplaceholdersfix
markpadbe Jun 6, 2024
13239e9
add additional optional chaining operator
markpadbe Jun 6, 2024
96d95a0
Merge branch 'stage' into mepplaceholdersfix
markpadbe Jun 10, 2024
6add147
MWPW-151561 [MILO][MEP] MEP button does not appear if Target is on bu…
vgoodric Jun 11, 2024
aaf150a
replace overridePersonalizationVariant function
markpadbe Jun 5, 2024
54e04cb
Fix chaining
markpadbe Jun 5, 2024
4a71225
Move parseMepParam
markpadbe Jun 5, 2024
5f3addd
add additional optional chaining operator
markpadbe Jun 6, 2024
eca39b0
MWPW-151561 [MILO][MEP] MEP button does not appear if Target is on bu…
vgoodric Jun 11, 2024
4bfc5f1
Merge branch 'mepplaceholdersfix' of https://github.com/adobecom/milo…
vgoodric Jun 11, 2024
e47df6a
Revert "MWPW-151561 [MILO][MEP] MEP button does not appear if Target …
vgoodric Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 19 additions & 23 deletions libs/features/personalization/personalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,11 @@ const checkForParamMatch = (paramStr) => {
};

async function getPersonalizationVariant(manifestPath, variantNames = [], variantLabel = null) {
const config = getConfig();
if (config.mep?.variantOverride[manifestPath]) {
markpadbe marked this conversation as resolved.
Show resolved Hide resolved
return config.mep.variantOverride[manifestPath];
}

const variantInfo = variantNames.reduce((acc, name) => {
let nameArr = [name];
if (!name.startsWith(TARGET_EXP_PREFIX)) nameArr = name.split(',');
Expand All @@ -572,7 +577,6 @@ async function getPersonalizationVariant(manifestPath, variantNames = [], varian

let userEntitlements = [];
if (hasEntitlementTag) {
const config = getConfig();
userEntitlements = await config.entitlements();
}

Expand Down Expand Up @@ -608,7 +612,7 @@ const createDefaultExperiment = (manifest) => ({
variants: {},
});

export async function getPersConfig(info, override = false) {
export async function getPersConfig(info, variantOverride = false) {
const {
name,
manifestData,
Expand All @@ -620,7 +624,7 @@ export async function getPersConfig(info, override = false) {
disabled,
event,
} = info;
if (disabled && !override) {
if (disabled && !variantOverride) {
return createDefaultExperiment(info);
}
let data = manifestData;
Expand Down Expand Up @@ -743,26 +747,19 @@ export async function categorizeActions(experiment) {
};
}

function overridePersonalizationVariant(manifest, config) {
const { manifestPath, variantNames } = manifest;
if (!config.mep?.override) return;
let selectedVariant;
config.mep?.override?.split('---').some((item) => {
function parseMepParam(mepParam) {
if (!mepParam) return false;
const mepObject = Object.create(null);
const decodedParam = decodeURIComponent(mepParam);
decodedParam.split('---').forEach((item) => {
const pair = item.trim().split('--');
if (pair[0] === manifestPath && pair.length > 1) {
[, selectedVariant] = pair;
return true;
if (pair.length > 1) {
const [manifestPath, selectedVariant] = pair;
mepObject[manifestPath] = selectedVariant;
}
return false;
});
if (!selectedVariant) return;
if (variantNames.includes(selectedVariant)) {
manifest.selectedVariantName = selectedVariant;
manifest.selectedVariant = manifest.variants[selectedVariant];
return;
}
manifest.selectedVariantName = selectedVariant;
manifest.selectedVariant = manifest.variants[selectedVariant];

return mepObject;
}

function compareExecutionOrder(a, b) {
Expand Down Expand Up @@ -793,7 +790,6 @@ export function cleanAndSortManifestList(manifests) {
} else {
manifestObj[manifest.manifestPath] = manifest;
}
if (config.mep?.override) overridePersonalizationVariant(manifest, config);
} catch (e) {
console.warn(e);
window.lana?.log(`MEP Error parsing manifests: ${e.toString()}`);
Expand Down Expand Up @@ -832,7 +828,7 @@ export async function applyPers(manifests, postLCP = false) {
handleFragmentCommand,
preview: (mepButton !== 'off'
&& (config.env?.name !== 'prod' || mepParam || mepParam === '' || mepButton)),
override: mepParam ? decodeURIComponent(mepParam) : '',
variantOverride: parseMepParam(mepParam),
highlight: (mepHighlight !== undefined && mepHighlight !== 'false'),
mepParam,
targetEnabled: config.mep?.targetEnabled,
Expand All @@ -842,7 +838,7 @@ export async function applyPers(manifests, postLCP = false) {
if (!manifests?.length) return;
let experiments = manifests;
for (let i = 0; i < experiments.length; i += 1) {
experiments[i] = await getPersConfig(experiments[i], config.mep?.override);
experiments[i] = await getPersConfig(experiments[i], config.mep?.variantOverride);
}

experiments = cleanAndSortManifestList(experiments);
Expand Down
Loading