Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwpw 142267: What's included style fixes #2674

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Mwpw 142267: What's included style fixes #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04c3c1
Mwpw 142267: What's included style fixes
Axelcureno Jul 31, 2024
002aeab
Merge branch 'stage' into MWPW-142267
Axelcureno Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libs/deps/mas/merch-mnemonic-list.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion libs/deps/mas/merch-whats-included.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions libs/features/mas/web-components/src/merch-mnemonic-list.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ export class MerchMnemonicList extends LitElement {
:host {
display: flex;
flex-direction: row;
gap: 10px;
margin-bottom: 10px;
gap: 5px;
margin-bottom: 5px;
margin-right: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reflected for RTL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout is the same for RTL geos in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds a bit odd, why is the layout not mirrored? Additionally, could you provide some testing details? I did visit the preview URL, but got a completely different modal than what was added here. I also switched to RTL to see how the modal reacts and I see the label covers the icon:
Screenshot 2024-08-07 at 12 00 55

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test the experience you have to click on "See all included apps" on the CC All Apps card:
Screenshot 2024-08-07 at 11 44 01 AM

The whole TwP experience is not yet build E2E though, but we decided to merge this WIP since our focus shifted to M@S v2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see, thanks for sharing! Not having RTL is still a bit odd, maybe you can open a story to address it in the future.

align-items: flex-end;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't center be better suited here?

}

Expand Down
1 change: 0 additions & 1 deletion libs/features/mas/web-components/src/merch-whats-included.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export class MerchWhatsIncluded extends LitElement {
place-content: stretch start;
box-sizing: border-box;
align-self: baseline;
margin-top: 16px;
margin-bottom: 16px;
grid-template-columns: repeat(auto-fill, minmax(200px, 1fr));
grid-auto-rows: unset;
Expand Down
Loading