-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(MWPW:151162):nofollow a individual link. #2692
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2692 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 172 172
Lines 45427 45445 +18
=======================================
+ Hits 43492 43511 +19
+ Misses 1935 1934 -1 ☔ View full report in Codecov by Sentry. |
It would be great if we can add a unit test for this |
Make sure to add this to https://milo.adobe.com/docs/authoring/links |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Validation done in given url with authoring as advised https://mwpw-151162--milosh--sharath-kannan.hlx.page/drafts/sharathkannan/media-container?martech=off |
Reminder to set the |
Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
2 similar comments
Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
This feature allows you to set the
rel='nofollow'
on a individual link in milo.#_blank
we can append#_nofollow
on a link to set the 'rel' attribute of an anchor tag to nofollow.Resolves: MWPW-151162
Test URLs: