Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(MWPW:151162):nofollow a individual link. #2692

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

sharath-kannan
Copy link
Contributor

@sharath-kannan sharath-kannan commented Aug 5, 2024

This feature allows you to set the rel='nofollow' on a individual link in milo.

Resolves: MWPW-151162

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (071a858) to head (64db8c5).
Report is 13 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2692   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files         172      172           
  Lines       45427    45445   +18     
=======================================
+ Hits        43492    43511   +19     
+ Misses       1935     1934    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mokimo
Copy link
Contributor

mokimo commented Aug 5, 2024

It would be great if we can add a unit test for this

@mokimo
Copy link
Contributor

mokimo commented Aug 5, 2024

Make sure to add this to https://milo.adobe.com/docs/authoring/links

Copy link
Contributor

github-actions bot commented Aug 6, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@spadmasa spadmasa self-assigned this Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage labels Aug 7, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 7, 2024

Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

2 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 8, 2024

Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 12, 2024

Skipped 2692: "Feat(MWPW:151162):nofollow a individual link." due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 2091558 into adobecom:stage Aug 13, 2024
20 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants